chrome/browser/resources/extensions/extension_load_error.html - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/extensions/extension_load_error.html

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Synchronized page loading, support multiple load errors Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/unpacked_installer.cc ('K') | « chrome/browser/extensions/unpacked_installer.cc ('k') | chrome/browser/resources/extensions/extension_loader.js » ('j') | chrome/browser/resources/extensions/extension_loader.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 Copyright 2014 The Chromium Authors. All rights reserved.	3 Copyright 2014 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be found	4 Use of this source code is governed by a BSD-style license that can be found

5 in the LICENSE file.	5 in the LICENSE file.

6 -->	6 -->

7 <div id="extension-load-error" hidden>	7 <div id="extension-load-error" hidden>

8 <h2 i18n-content="extensionLoadErrorHeading">Extension Load Error</h2>	8 <h2 i18n-content="extensionLoadErrorHeading">Extension Load Error</h2>

9 <div id="extension-load-error-message">	9 <div id="extension-load-error-message">

10 <span i18n-content="extensionLoadErrorMessage"></span>	10 <span i18n-content="extensionLoadErrorMessage"></span>

11 <span id="extension-load-error-path"></span>	11 <span id="extension-load-error-path"></span>

12 </div>	12 </div>

13 <span id="extension-load-error-reason"></span>	13 <span id="extension-load-error-reason"></span>

14 <div id="extension-load-error-manifest" class="extension-code"></div>	14 <div id="extension-load-error-manifest" class="extension-code"></div>

15 <div id="extension-load-error-controls">	15 <div id="extension-load-error-controls">

16 <button id="extension-load-error-retry-button"	16 <button id="extension-load-error-retry-button"

17 i18n-content="extensionLoadErrorRetry"></button>	17 i18n-content="extensionLoadErrorRetry"></button>

18 <button id="extension-load-error-give-up-button"	18 <button id="extension-load-error-give-up-button"

19 i18n-content="extensionLoadErrorGiveUp"></button>	19 i18n-content="extensionLoadErrorGiveUp"></button>

20 </div>	20 </div>

	21 <div id="extension-load-error-additional">
	Devlin 2014/06/27 22:31:08 these don't both need ids. these don't both need ids. gpdavis 2014/06/28 02:31:17 Done. Show quoted text On 2014/06/27 22:31:08, Devlin wrote: > these don't both need ids. Done.
	22 <pre id="extension-load-error-additional-list"></pre>

	23 </div>
	Devlin 2014/06/27 22:31:08 Any UI for this will have to go through review... Any UI for this will have to go through review... but we'll get to that later. gpdavis 2014/06/27 23:42:54 Understood. I figured if I could get the necessar Understood. I figured if I could get the necessary architectural changes done, the UI stuff could be figured out afterward.
21 </div>	24 </div>

OLD	NEW