Show alert failure for reloading unpacked extensions with bad manifest

chrome/browser/extensions/extension_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 219 matching lines @@
   void SetBeingReloaded(const std::string& extension_id, bool value);
 
   // Initialize and start all installed extensions.
   void Init();
 
   // Called when the associated Profile is going to be destroyed.
   void Shutdown();
 
   // Reloads the specified extension, sending the onLaunched() event to it if it
   // currently has any window showing.
-  void ReloadExtension(const std::string& extension_id);
+  // Public method for ReloadExtensionImpl. Allows noisy failures.

[Devlin, 2014/07/07 20:44:21]

No point in saying "Public method for x".  Just say "Allows noisy failure."

[gpdavis, 2014/07/09 01:35:56]

Done.

+  void ReloadExtension(const std::string& extension_id) {
+    ReloadExtensionImpl(extension_id, true /* be_noisy */);

[Devlin, 2014/07/07 20:44:21]

These calls should actually be in the .cc file.

[gpdavis, 2014/07/09 01:35:56]

Done.

+  }
+
+  // Public method for ReloadExtensionImpl. Suppresses noisy failures.
+  void ReloadExtensionWithQuietFailure(const std::string& extension_id) {
+    ReloadExtensionImpl(extension_id, false /* be_noisy */);
+  }
 
   // Uninstalls the specified extension. Callers should only call this method
   // with extensions that exist. |external_uninstall| is a magical parameter
   // that is only used to send information to ExtensionPrefs, which external
   // callers should never set to true.
   //
   // TODO(aa): Remove |external_uninstall| -- this information should be passed
   // to ExtensionPrefs some other way.
   virtual bool UninstallExtension(const std::string& extension_id,
                                   bool external_uninstall,
@@ skipping 184 matching lines @@
 
   // Set a callback to be called when all external providers are ready and their
   // extensions have been installed.
   void set_external_updates_finished_callback_for_test(
       const base::Closure& callback) {
     external_updates_finished_callback_ = callback;
   }
 
 
  private:
+  // Reloads the specified extension, sending the onLaunched() event to it if it
+  // currently has any window showing. |be_noisy| determines whether noisy
+  // failures are allowed for unpacked extension installs.
+  void ReloadExtensionImpl(const std::string& extension_id, bool be_noisy);
+
   // content::NotificationObserver implementation:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // extensions::Blacklist::Observer implementation.
   virtual void OnBlacklistUpdated() OVERRIDE;
 
   // Similar to FinishInstallation, but first checks if there still is an update
   // pending for the extension, and makes sure the extension is still idle.
@@ skipping 260 matching lines @@
                            GreylistedExtensionDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistDontEnableManuallyDisabled);
   FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
                            GreylistUnknownDontChange);
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionService);
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_