chrome/browser/extensions/extension_error_reporter_observer.h - Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/extension_error_reporter_observer.h

Issue 342003005: Show alert failure for reloading unpacked extensions with bad manifest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/extension_error_reporter.cc ('K') | « chrome/browser/extensions/extension_error_reporter.cc ('k') | chrome/browser/extensions/unpacked_installer.cc » ('j') | chrome/browser/extensions/unpacked_installer.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_ERROR_REPORTER_OBSERVER_H_

	6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_ERROR_REPORTER_OBSERVER_H_

	7

	8 #include "extensions/common/extension.h"

	9

	10 class Extension;

	11

	12 class ExtensionErrorReporterObserver {
	Devlin 2014/06/24 22:21:12 This class is small enough and should have few eno This class is small enough and should have few enough implementors that it can be nested as an inner class in ExtensionErrorReporter.
	13 public:

	14 virtual ~ExtensionErrorReporterObserver() {}

	15

	16 virtual void OnLoadFailure(const base::FilePath& extension_path,

	17 const std::string& error) {}
	Devlin 2014/06/24 22:21:12 Since this is the only method, we should make it p Since this is the only method, we should make it pure virtual.
	18 };

	19

	20 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_ERROR_REPORTER_OBSERVER_H_

OLD	NEW