Show alert failure for reloading unpacked extensions with bad manifest

chrome/browser/extensions/extension_error_reporter.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_error_reporter.h"
+#include "chrome/browser/extensions/extension_error_reporter_observer.h"

[Devlin, 2014/06/24 22:21:12]

Only the associated .h file goes at the top, all others in the main bunch.

 
 #include "build/build_config.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 32 matching lines @@
       chrome::NOTIFICATION_EXTENSION_LOAD_ERROR,
       content::Source<Profile>(profile),
       content::Details<const std::string>(&error));
 
   std::string path_str = base::UTF16ToUTF8(extension_path.LossyDisplayName());
   base::string16 message = base::UTF8ToUTF16(
       base::StringPrintf("Could not load extension from '%s'. %s",
                          path_str.c_str(),
                          error.c_str()));
   ReportError(message, be_noisy);
+  TriggerOnLoadFailure(extension_path, error);

[Devlin, 2014/06/24 22:21:12]

You can just inline the notification here.

 }
 
 void ExtensionErrorReporter::ReportError(const base::string16& message,
                                          bool be_noisy) {
   // NOTE: There won't be a ui_loop_ in the unit test environment.
   if (ui_loop_) {
     CHECK(base::MessageLoop::current() == ui_loop_)
         << "ReportError can only be called from the UI thread.";
   }
 
@@ skipping 11 matching lines @@
   }
 }
 
 const std::vector<base::string16>* ExtensionErrorReporter::GetErrors() {
   return &errors_;
 }
 
 void ExtensionErrorReporter::ClearErrors() {
   errors_.clear();
 }
+
+void ExtensionErrorReporter::AddObserver(

[Devlin, 2014/06/24 22:21:11]

Methods should be defined in the .cc in the same order they were declared in the
.h.

[gpdavis, 2014/06/25 00:21:01]

They are implemented in the same order as in the header, but should the
AddObserver and RemoveObserver methods be higher up in the header and cc file?

[Devlin, 2014/06/25 19:49:36]

Whoops, you're right, my bad.

+    ExtensionErrorReporterObserver* observer) {
+  observers_.AddObserver(observer);
+}
+
+void ExtensionErrorReporter::RemoveObserver(
+    ExtensionErrorReporterObserver* observer) {
+  observers_.RemoveObserver(observer);
+}
+
+void ExtensionErrorReporter::TriggerOnLoadFailure(
+    const base::FilePath& extension_path,
+    const std::string& error) {
+  FOR_EACH_OBSERVER(ExtensionErrorReporterObserver,
+                    observers_,
+                    OnLoadFailure(extension_path, error));
+}