Issue 341983012: OTS: Add DoNotDropColorBitmapTables() API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341983012: OTS: Add DoNotDropColorBitmapTables() API. (Closed)

Created:
6 years, 6 months ago by bashi

Modified:
6 years, 6 months ago

Reviewers:
Kunihiko Sakamoto

CC:
chromium-reviews

Base URL:
http://ots.googlecode.com/svn/

Visibility:
Public.

More Reviews

Description

Add DoNotDropColorBitmapTables() API. Adding a API not to drop CBDT/CBLC tables. OTS doesn't recognize the tables for now, but trusts users of this API, assuming users exactly know the risks. BUG=324187 R=ksakamoto@chromium.org Committed: 114

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+160 lines, -5 lines)			Patch
M	trunk/include/opentype-sanitiser.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/ots-common.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	trunk/ots-standalone.gyp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	trunk/src/cbdt.h	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	trunk/src/cbdt.cc	View	1 chunk	+41 lines, -0 lines	0 comments	Download
A	trunk/src/cblc.h	View	1 chunk	+24 lines, -0 lines	0 comments	Download
A	trunk/src/cblc.cc	View	1 chunk	+41 lines, -0 lines	0 comments	Download
M	trunk/src/cmap.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	trunk/src/ots.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	trunk/src/ots.cc	View	4 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bashi

On 2014/06/27 06:17:17, Kunihiko Sakamoto wrote: > lgtm > I assume you manually tested the ...

6 years, 6 months ago (2014-06-27 06:22:45 UTC) #3

bashi

6 years, 6 months ago (2014-06-27 06:25:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r114 (presubmit successful).

Expand Messages | Collapse Messages