Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 341973002: Revert of Disable excluding of tested apk's code in test apks (Closed)

Created:
6 years, 6 months ago by Yusuf
Modified:
6 years, 6 months ago
Reviewers:
aberent, cjhopman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert of Disable excluding of tested apk's code in test apks (https://codereview.chromium.org/331683005/) Reason for revert: We are hitting the issue in https://code.google.com/p/chromium/issues/detail?id=272790 again. So we will have to reenable this fix. The failing tests are being handled in separate CLs I believe. Original issue's description: > The new way of building test APKs loses some > necessary classes from them, hence causing them to fail with > "Class not found" errors. > > Disable this until we have a fix. > > BUG=384537, 272790 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277756 TBR=aberent@chromium.org,cjhopman@chromium.org NOTREECHECKS=true NOTRY=true BUG=384537, 272790 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278118

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/java_apk.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yusuf
Created Revert of Disable excluding of tested apk's code in test apks
6 years, 6 months ago (2014-06-18 17:49:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusufo@chromium.org/341973002/1
6 years, 6 months ago (2014-06-18 17:51:18 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 17:53:49 UTC) #3
Message was sent while issue was closed.
Change committed as 278118

Powered by Google App Engine
This is Rietveld 408576698