Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 341953002: Clean up WTH creation (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Clean up WTH creation WTHMojo was unable to observe bounds changes from its associated Node. Instead WTHMojo is now bound to a Node & derives bounds from it. R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278614

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -184 lines) Patch
M mojo/aura/window_tree_host_mojo.h View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M mojo/aura/window_tree_host_mojo.cc View 2 chunks +20 lines, -2 lines 0 comments Download
M mojo/examples/aura_demo/aura_demo.cc View 5 chunks +26 lines, -150 lines 0 comments Download
M mojo/examples/browser/browser.cc View 1 5 chunks +6 lines, -8 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/mojo_services.gypi View 1 2 chunks +3 lines, -1 line 0 comments Download
M mojo/services/view_manager/root_view_manager.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/services/view_manager/screen_impl.h View 1 3 chunks +13 lines, -9 lines 0 comments Download
A mojo/services/view_manager/screen_impl.cc View 1 1 chunk +80 lines, -0 lines 0 comments Download
M mojo/views/native_widget_view_manager.h View 3 chunks +5 lines, -3 lines 0 comments Download
M mojo/views/native_widget_view_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ben Goodger (Google)
6 years, 6 months ago (2014-06-18 17:35:16 UTC) #1
sky
This is fine, but currently the window_tree_host_mojo is in the mojo_aura_support target. mojo_view_manager depends upon ...
6 years, 6 months ago (2014-06-18 17:58:46 UTC) #2
Ben Goodger (Google)
updated.
6 years, 6 months ago (2014-06-19 20:02:23 UTC) #3
sky
LGTM
6 years, 6 months ago (2014-06-19 20:09:23 UTC) #4
Ben Goodger (Google)
The CQ bit was checked by ben@chromium.org
6 years, 6 months ago (2014-06-19 21:36:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/341953002/40001
6 years, 6 months ago (2014-06-19 21:41:09 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 05:23:54 UTC) #7
Message was sent while issue was closed.
Change committed as 278614

Powered by Google App Engine
This is Rietveld 408576698