Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Side by Side Diff: chrome/browser/android/most_visited_sites.h

Issue 341943002: [Android NTP] Logging histograms for users that are part of a control group. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/android/most_visited_sites.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_ 5 #ifndef CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_
6 #define CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_ 6 #define CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/scoped_java_ref.h" 10 #include "base/android/scoped_java_ref.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 91
92 // The profile whose most visited sites will be queried. 92 // The profile whose most visited sites will be queried.
93 Profile* profile_; 93 Profile* profile_;
94 94
95 // The observer to be notified when the list of most visited sites changes. 95 // The observer to be notified when the list of most visited sites changes.
96 base::android::ScopedJavaGlobalRef<jobject> observer_; 96 base::android::ScopedJavaGlobalRef<jobject> observer_;
97 97
98 // The maximum number of most visited sites to return. 98 // The maximum number of most visited sites to return.
99 int num_sites_; 99 int num_sites_;
100 100
101 // Whether the user is in a control group for the purposes of logging.
102 bool is_control_group_;
103
101 // Counters for UMA metrics. 104 // Counters for UMA metrics.
102 105
103 // Number of tiles using a local thumbnail image for this NTP session. 106 // Number of tiles using a local thumbnail image for this NTP session.
104 int num_local_thumbs_; 107 int num_local_thumbs_;
105 // Number of tiles for which a server thumbnail is provided. 108 // Number of tiles for which a server thumbnail is provided.
106 int num_server_thumbs_; 109 int num_server_thumbs_;
107 // Number of tiles for which no thumbnail is found/specified and a gray tile 110 // Number of tiles for which no thumbnail is found/specified and a gray tile
108 // is used as the main tile. 111 // is used as the main tile.
109 int num_empty_thumbs_; 112 int num_empty_thumbs_;
110 113
111 // Copy of the server suggestions (if enabled). Used for logging. 114 // Copy of the server suggestions (if enabled). Used for logging.
112 suggestions::SuggestionsProfile server_suggestions_; 115 suggestions::SuggestionsProfile server_suggestions_;
113 116
114 // For callbacks may be run after destruction. 117 // For callbacks may be run after destruction.
115 base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_; 118 base::WeakPtrFactory<MostVisitedSites> weak_ptr_factory_;
116 119
117 content::NotificationRegistrar registrar_; 120 content::NotificationRegistrar registrar_;
118 121
119 // The source of the Most Visited sites. 122 // The source of the Most Visited sites.
120 enum MostVisitedSource { 123 enum MostVisitedSource {
121 TOP_SITES, 124 TOP_SITES,
122 SUGGESTIONS_SERVICE 125 SUGGESTIONS_SERVICE
123 }; 126 };
124 MostVisitedSource mv_source_; 127 MostVisitedSource mv_source_;
125 128
126 DISALLOW_COPY_AND_ASSIGN(MostVisitedSites); 129 DISALLOW_COPY_AND_ASSIGN(MostVisitedSites);
127 }; 130 };
128 131
129 #endif // CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_ 132 #endif // CHROME_BROWSER_ANDROID_MOST_VISITED_SITES_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/most_visited_sites.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698