Issue 341893005: [NaCl SDK] create_html.py now adds PS_TTY_PREFIX attribute to NaCl embed.

Issue 341893005: [NaCl SDK] create_html.py now adds PS_TTY_PREFIX attribute to NaCl embed. (Closed)

Created:
6 years, 6 months ago by Sam Clegg

Modified:
6 years, 6 months ago

Reviewers:
binji

CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] create_html.py now adds PS_TTY_PREFIX attribute to NaCl embed. This fixes tty output handling for ppapi_simple-based applications.

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -8 lines)			Patch
	M	native_client_sdk/src/tools/create_html.py	View		3 chunks	+14 lines, -8 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

binji

lgtm https://codereview.chromium.org/341893005/diff/1/native_client_sdk/src/tools/create_html.py File native_client_sdk/src/tools/create_html.py (right): https://codereview.chromium.org/341893005/diff/1/native_client_sdk/src/tools/create_html.py#newcode75 native_client_sdk/src/tools/create_html.py:75: var prefix = "tty:"; I'd like to remove ...

6 years, 6 months ago (2014-06-18 20:43:32 UTC) #2

Sam Clegg

https://codereview.chromium.org/341893005/diff/1/native_client_sdk/src/tools/create_html.py File native_client_sdk/src/tools/create_html.py (right): https://codereview.chromium.org/341893005/diff/1/native_client_sdk/src/tools/create_html.py#newcode75 native_client_sdk/src/tools/create_html.py:75: var prefix = "tty:"; On 2014/06/18 20:43:32, binji wrote: ...

6 years, 6 months ago (2014-06-18 20:48:38 UTC) #3

Message was sent while issue was closed.

Committed as r278167

Expand Messages | Collapse Messages