Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 341893002: Use libaddressinput revision 293. (Closed)

Created:
6 years, 6 months ago by please use gerrit instead
Modified:
6 years, 6 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use libaddressinput revision 293. Changes from r282: - Add a comma between city and state for US. - Show only one example postal code in error messages. - Addresses with Latin script names are now valid. - Pass UI language to BuildComponents instead of Localization. TBR=estade@chromium.org BUG=327046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278308

Patch Set 1 #

Patch Set 2 : r293 to fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/libaddressinput/README.chromium View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
please use gerrit instead
FYI
6 years, 6 months ago (2014-06-18 16:46:25 UTC) #1
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-18 16:46:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/341893002/1
6 years, 6 months ago (2014-06-18 16:48:19 UTC) #3
please use gerrit instead
The CQ bit was unchecked by rouslan@chromium.org
6 years, 6 months ago (2014-06-18 17:44:11 UTC) #4
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-18 18:28:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/341893002/20001
6 years, 6 months ago (2014-06-18 18:29:28 UTC) #6
please use gerrit instead
The CQ bit was unchecked by rouslan@chromium.org
6 years, 6 months ago (2014-06-19 03:20:53 UTC) #7
please use gerrit instead
The CQ bit was checked by rouslan@chromium.org
6 years, 6 months ago (2014-06-19 03:21:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/341893002/20001
6 years, 6 months ago (2014-06-19 03:21:23 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 08:53:10 UTC) #10
Message was sent while issue was closed.
Change committed as 278308

Powered by Google App Engine
This is Rietveld 408576698