Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Side by Side Diff: content/browser/devtools/devtools_power_handler.cc

Issue 341853002: [PowerProfiler] Power profiler service keeps running even after devtools frontend has been closed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@power-profiler-devtools-crash-fix
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/devtools/devtools_power_handler.h" 5 #include "content/browser/devtools/devtools_power_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "content/browser/devtools/devtools_protocol_constants.h" 9 #include "content/browser/devtools/devtools_protocol_constants.h"
10 #include "content/browser/power_profiler/power_profiler_service.h" 10 #include "content/browser/power_profiler/power_profiler_service.h"
11 #include "content/public/browser/devtools_manager.h"
11 12
12 namespace content { 13 namespace content {
13 14
14 DevToolsPowerHandler::DevToolsPowerHandler() { 15 DevToolsPowerHandler::DevToolsPowerHandler(
16 DevToolsAgentHost* devtools_agent_host)
17 : devtools_agent_host_(devtools_agent_host),
18 devtools_callback_(
19 base::Bind(&DevToolsPowerHandler::OnDevToolsStateChanged,
20 base::Unretained(this))) {
15 RegisterCommandHandler(devtools::Power::start::kName, 21 RegisterCommandHandler(devtools::Power::start::kName,
16 base::Bind(&DevToolsPowerHandler::OnStart, 22 base::Bind(&DevToolsPowerHandler::OnStart,
17 base::Unretained(this))); 23 base::Unretained(this)));
18 RegisterCommandHandler(devtools::Power::end::kName, 24 RegisterCommandHandler(devtools::Power::end::kName,
19 base::Bind(&DevToolsPowerHandler::OnEnd, 25 base::Bind(&DevToolsPowerHandler::OnEnd,
20 base::Unretained(this))); 26 base::Unretained(this)));
21 RegisterCommandHandler(devtools::Power::canProfilePower::kName, 27 RegisterCommandHandler(devtools::Power::canProfilePower::kName,
22 base::Bind(&DevToolsPowerHandler::OnCanProfilePower, 28 base::Bind(&DevToolsPowerHandler::OnCanProfilePower,
23 base::Unretained(this))); 29 base::Unretained(this)));
30 content::DevToolsManager::GetInstance()->AddAgentStateCallback(
31 devtools_callback_);
24 } 32 }
25 33
26 DevToolsPowerHandler::~DevToolsPowerHandler() { 34 DevToolsPowerHandler::~DevToolsPowerHandler() {
27 PowerProfilerService::GetInstance()->RemoveObserver(this); 35 PowerProfilerService::GetInstance()->RemoveObserver(this);
36 content::DevToolsManager::GetInstance()->RemoveAgentStateCallback(
37 devtools_callback_);
28 } 38 }
29 39
30 void DevToolsPowerHandler::OnPowerEvent(const PowerEventVector& events) { 40 void DevToolsPowerHandler::OnPowerEvent(const PowerEventVector& events) {
31 base::DictionaryValue* params = new base::DictionaryValue(); 41 base::DictionaryValue* params = new base::DictionaryValue();
32 base::ListValue* event_list = new base::ListValue(); 42 base::ListValue* event_list = new base::ListValue();
33 43
34 std::vector<PowerEvent>::const_iterator iter; 44 std::vector<PowerEvent>::const_iterator iter;
35 for (iter = events.begin(); iter != events.end(); ++iter) { 45 for (iter = events.begin(); iter != events.end(); ++iter) {
36 base::DictionaryValue* event_body = new base::DictionaryValue(); 46 base::DictionaryValue* event_body = new base::DictionaryValue();
37 47
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 scoped_refptr<DevToolsProtocol::Response> 83 scoped_refptr<DevToolsProtocol::Response>
74 DevToolsPowerHandler::OnCanProfilePower( 84 DevToolsPowerHandler::OnCanProfilePower(
75 scoped_refptr<DevToolsProtocol::Command> command) { 85 scoped_refptr<DevToolsProtocol::Command> command) {
76 base::DictionaryValue* result = new base::DictionaryValue(); 86 base::DictionaryValue* result = new base::DictionaryValue();
77 result->SetBoolean(devtools::kResult, 87 result->SetBoolean(devtools::kResult,
78 PowerProfilerService::GetInstance()->IsAvailable()); 88 PowerProfilerService::GetInstance()->IsAvailable());
79 89
80 return command->SuccessResponse(result); 90 return command->SuccessResponse(result);
81 } 91 }
82 92
93 void DevToolsPowerHandler::OnDevToolsStateChanged(
94 content::DevToolsAgentHost* agent_host,
95 bool attached) {
96 if (!attached && agent_host == devtools_agent_host_) {
97 PowerProfilerService::GetInstance()->RemoveObserver(this);
98 }
99 }
100
83 } // namespace content 101 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698