samples/third_party/todomvc_performance/web/lib-elements/simple_router.dart - Issue 341843003: Remove use of deprecated property in TodoMVC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/third_party/todomvc_performance/web/lib-elements/simple_router.dart

Issue 341843003: Remove use of deprecated property in TodoMVC (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « samples/third_party/todomvc/web/lib-elements/simple_router.dart ('k') | samples/tracker/web/elements/task_form_element.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: samples/third_party/todomvc_performance/web/lib-elements/simple_router.dart

diff --git a/samples/third_party/todomvc_performance/web/lib-elements/simple_router.dart b/samples/third_party/todomvc_performance/web/lib-elements/simple_router.dart

index 9e672db9b144f0c5bf4303632e158cc3af3d89a3..1337a262f6f04b5dedd65b7d8b9c9d44d739dc0c 100644

--- a/samples/third_party/todomvc_performance/web/lib-elements/simple_router.dart

+++ b/samples/third_party/todomvc_performance/web/lib-elements/simple_router.dart

@@ -18,7 +18,8 @@ class SimpleRouter extends PolymerElement {

factory SimpleRouter() => new Element.tag('simple-router');

SimpleRouter.created() : super.created();

- enteredView() {

+ attached() {

+ super.attached();

_sub = windowLocation.changes.listen((_) {

var hash = window.location.hash;

if (hash.startsWith('#/')) hash = hash.substring(2);

@@ -29,7 +30,8 @@ class SimpleRouter extends PolymerElement {

});

}

- leftView() {

+ detached() {

+ super.detached();

_sub.cancel();

}