Fix undefined default_config_path_bak in gsutil config.

Fix undefined default_config_path_bak in gsutil config.

This is already fixed upstream in gsutil.


BUG=None.
TEST=None.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=280386

[Ryan Tseng, 2014-06-23 21:29:22]

lgtm % comment

https://codereview.chromium.org/341833005/diff/1/third_party/gsutil/gslib/com...
File third_party/gsutil/gslib/commands/config.py (right):

https://codereview.chromium.org/341833005/diff/1/third_party/gsutil/gslib/com...
third_party/gsutil/gslib/commands/config.py:629: default_config_path_bak = None
Move this before 597 before the if (to make it more obvious it has to exist in
the scope of this function).

[M-A Ruel, 2014-06-25 01:28:18]

Could you fix it upstream too so that it's not a required fix next time it's
rolled in.

[iannucci, 2014-06-25 01:59:25]

On 2014/06/25 01:28:18, M-A Ruel wrote:
> Could you fix it upstream too so that it's not a required fix next time it's
> rolled in.

+inf. This file is a copy of the upstream gsutil library and needs to be fixed
there, then rolled in.

[M-A Ruel, 2014-06-25 02:03:26]

On 2014/06/25 01:59:25, iannucci wrote:
> On 2014/06/25 01:28:18, M-A Ruel wrote:
> > Could you fix it upstream too so that it's not a required fix next time it's
> > rolled in.
> 
> +inf. This file is a copy of the upstream gsutil library and needs to be fixed
> there, then rolled in.

That's not what the CL description says, please note this accordingly in the CL
description.

[Ryan Tseng, 2014-06-25 02:07:34]

This is a pretty heavily modified version of gsutil, but this line just happens
to be vanilla.  No need to upstream -> roll.

gsutil is clopen sourced - the github version is merely a periodic mirror.  But
I'm sure sending a pull request to the project will probably work.

[dtu, 2014-06-26 23:02:19]

It looks like this is already fixed upstream [1].
What's the correct thing to do here? Copy the fix here with a note in the CL
description?

[1]
https://github.com/GoogleCloudPlatform/gsutil/blob/master/gslib/commands/conf...

[M-A Ruel, 2014-06-27 02:28:59]

On 2014/06/26 23:02:19, dtu wrote:
> It looks like this is already fixed upstream [1].
> What's the correct thing to do here? Copy the fix here with a note in the CL
> description?
> 
> [1]
>
https://github.com/GoogleCloudPlatform/gsutil/blob/master/gslib/commands/conf...

Oh it's fine, I just forgot to reply;

lgtm

[dtu, 2014-06-27 19:52:49]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-06-27 19:53:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/341833005/20001

[commit-bot: I haz the power, 2014-06-27 19:55:56]

Change committed as 280386