Issue 341833004: [WebsiteSettings] Enable permission bubbles by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341833004: [WebsiteSettings] Enable permission bubbles by default.

Created:
6 years, 6 months ago by Greg Billock

Modified:
6 years, 4 months ago

Reviewers:

CC:
chromium-reviews, markusheintz_

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

[WebsiteSettings] Enable permission bubbles by default.

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : . #

Patch Set 4 : geolocation test #

Patch Set 5 : download test, bubble mgr test #

Patch Set 6 : interactive ui test #

Patch Set 7 : . #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Patch Set 10 : fix rebase #

Patch Set 11 : fix merge #

Patch Set 12 : fix patch again #

Patch Set 13 : rebase #

Patch Set 14 : Working media stream test #

Patch Set 15 : WebViewTest working #

Patch Set 16 : rebase #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1132 lines, -292 lines)			Patch
M	chrome/browser/chrome_quota_permission_context.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14	2 chunks	+11 lines, -9 lines	0 comments	Download
M	chrome/browser/content_settings/permission_context_base_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12	4 chunks	+24 lines, -4 lines	0 comments	Download
M	chrome/browser/download/download_permission_request.cc	View	1 2 3 4	1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/download/download_request_limiter_unittest.cc	View	1 2 3 4 5 6 7 8 9 10	10 chunks	+16 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_browsertest.cc	View	1 2 3 4 5 6 7 8 9 10	26 chunks	+238 lines, -104 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_permission_context.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_permission_context_unittest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	31 chunks	+499 lines, -48 lines	0 comments	Download
M	chrome/browser/media/chrome_media_stream_infobar_browsertest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	8 chunks	+70 lines, -24 lines	0 comments	Download
M	chrome/browser/media/media_stream_devices_controller.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/media/webrtc_browsertest_base.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	5 chunks	+48 lines, -21 lines	0 comments	Download
M	chrome/browser/notifications/notification_browsertest.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13 14 15	19 chunks	+198 lines, -73 lines	0 comments	Download
M	chrome/browser/ui/website_settings/permission_bubble_manager.h	View	1 2 3 4 5 6 7 8 9 10 11 12 13	1 chunk	+6 lines, -1 line	0 comments	Download
M	chrome/browser/ui/website_settings/permission_bubble_manager.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	6 chunks	+12 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/test/data/geolocation/simple.html	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+1 line, -0 lines	0 comments	Download