Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 341803002: DevTools: Support properly multiple targets in sources panel (Closed)

Created:
6 years, 6 months ago by sergeyv
Modified:
6 years, 6 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Support properly multiple targets in sources panel BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176541

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address vsevik's comments #

Total comments: 8

Patch Set 3 : Address vsevik's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -75 lines) Patch
M LayoutTests/http/tests/inspector/debugger-test.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 1 2 5 chunks +19 lines, -0 lines 0 comments Download
M Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sources/SourcesPanel.js View 1 2 18 chunks +126 lines, -68 lines 0 comments Download
M Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
sergeyv
6 years, 6 months ago (2014-06-18 09:43:26 UTC) #1
vsevik
https://codereview.chromium.org/341803002/diff/1/Source/devtools/front_end/sdk/DebuggerModel.js File Source/devtools/front_end/sdk/DebuggerModel.js (right): https://codereview.chromium.org/341803002/diff/1/Source/devtools/front_end/sdk/DebuggerModel.js#newcode182 Source/devtools/front_end/sdk/DebuggerModel.js:182: this.dispatchEventToListeners(WebInspector.DebuggerModel.Events.DebuggerWasDisabled, this.target()); No need, you could extract target by ...
6 years, 6 months ago (2014-06-18 13:51:48 UTC) #2
sergeyv
https://codereview.chromium.org/341803002/diff/1/Source/devtools/front_end/sdk/DebuggerModel.js File Source/devtools/front_end/sdk/DebuggerModel.js (right): https://codereview.chromium.org/341803002/diff/1/Source/devtools/front_end/sdk/DebuggerModel.js#newcode182 Source/devtools/front_end/sdk/DebuggerModel.js:182: this.dispatchEventToListeners(WebInspector.DebuggerModel.Events.DebuggerWasDisabled, this.target()); On 2014/06/18 17:51:47, vsevikwrote: > No need, ...
6 years, 6 months ago (2014-06-19 12:42:04 UTC) #3
vsevik
lgtm https://codereview.chromium.org/341803002/diff/20001/Source/devtools/front_end/sdk/DebuggerModel.js File Source/devtools/front_end/sdk/DebuggerModel.js (right): https://codereview.chromium.org/341803002/diff/20001/Source/devtools/front_end/sdk/DebuggerModel.js#newcode249 Source/devtools/front_end/sdk/DebuggerModel.js:249: this._waitingToPause = true; _isPausing https://codereview.chromium.org/341803002/diff/20001/Source/devtools/front_end/sources/SourcesPanel.js File Source/devtools/front_end/sources/SourcesPanel.js (right): ...
6 years, 6 months ago (2014-06-19 15:30:40 UTC) #4
sergeyv
https://codereview.chromium.org/341803002/diff/20001/Source/devtools/front_end/sdk/DebuggerModel.js File Source/devtools/front_end/sdk/DebuggerModel.js (right): https://codereview.chromium.org/341803002/diff/20001/Source/devtools/front_end/sdk/DebuggerModel.js#newcode249 Source/devtools/front_end/sdk/DebuggerModel.js:249: this._waitingToPause = true; On 2014/06/19 19:30:39, vsevikwrote: > _isPausing ...
6 years, 6 months ago (2014-06-19 17:02:45 UTC) #5
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 6 months ago (2014-06-19 17:02:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/341803002/40001
6 years, 6 months ago (2014-06-19 17:03:27 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 19:30:09 UTC) #8
Message was sent while issue was closed. 
Change committed as 176541

Powered by Google App Engine
This is Rietveld 408576698