Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 341783002: Files.app: Add Incognito test for file dialogs. (Closed)

Created:
6 years, 6 months ago by hirono
Modified:
6 years, 6 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: Add Incognito test for file dialogs. BUG=380825 TEST=run the test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278078

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 6 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 6 months ago (2014-06-18 08:37:46 UTC) #1
kinaba
Thank you very very much! lgtm!!
6 years, 6 months ago (2014-06-18 08:41:38 UTC) #2
kinaba
Thank you very very much! lgtm!!
6 years, 6 months ago (2014-06-18 08:41:39 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 6 months ago (2014-06-18 08:43:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/341783002/1
6 years, 6 months ago (2014-06-18 08:45:14 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 15:14:12 UTC) #6
Message was sent while issue was closed.
Change committed as 278078

Powered by Google App Engine
This is Rietveld 408576698