Ensure that mouse events on Windows reposted by the menu_controller are converted to pixel.

ui/views/controls/menu/menu_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_controller.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/time/time.h"
@@ skipping 21 matching lines @@
 #include "ui/views/mouse_constants.h"
 #include "ui/views/view.h"
 #include "ui/views/view_constants.h"
 #include "ui/views/views_delegate.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/tooltip_manager.h"
 #include "ui/views/widget/widget.h"
 
 #if defined(OS_WIN)
 #include "ui/base/win/internal_constants.h"
+#include "ui/gfx/win/dpi.h"
 #include "ui/views/win/hwnd_util.h"
 #endif
 
 using base::Time;
 using base::TimeDelta;
 using ui::OSExchangeData;
 
 // Period of the scroll timer (in milliseconds).
 static const int kScrollTimerMS = 30;
 
@@ skipping 1992 matching lines @@
   gfx::Point screen_loc(event.location());
   View::ConvertPointToScreen(source->GetScrollViewContainer(), &screen_loc);
   gfx::NativeView native_view = source->GetWidget()->GetNativeView();
   if (!native_view)
     return;
 
   gfx::Screen* screen = gfx::Screen::GetScreenFor(native_view);
   gfx::NativeWindow window = screen->GetWindowAtScreenPoint(screen_loc);
 
 #if defined(OS_WIN)
+  // Convert screen_loc to pixels for the Win32 API's like WindowFromPoint,
+  // PostMessage/SendMessage to work correctly. These API's expect the
+  // coordinates to be in pixels.
+  gfx::Point screen_loc_pixels = gfx::win::DIPToScreenPoint(screen_loc);

[sky, 2014/06/19 15:33:32]

nit: move into conditional block below, it's only needed there.

[ananta, 2014/06/19 18:45:26]

Done.

   // PostMessage() to metro windows isn't allowed (access will be denied). Don't
   // try to repost with Win32 if the window under the mouse press is in metro.
   if (!ViewsDelegate::views_delegate ||
       !ViewsDelegate::views_delegate->IsWindowInMetro(window)) {
     HWND target_window = window ? HWNDForNativeWindow(window) :
-                                  WindowFromPoint(screen_loc.ToPOINT());
+                                  WindowFromPoint(screen_loc_pixels.ToPOINT());
     HWND source_window = HWNDForNativeView(native_view);
     if (!target_window || !source_window ||
         GetWindowThreadProcessId(source_window, NULL) !=
         GetWindowThreadProcessId(target_window, NULL)) {
       // Even though we have mouse capture, windows generates a mouse event if
       // the other window is in a separate thread. Only repost an event if
       // |target_window| and |source_window| were created on the same thread,
       // else double events can occur and lead to bad behavior.
       return;
     }
 
     // Determine whether the click was in the client area or not.
     // NOTE: WM_NCHITTEST coordinates are relative to the screen.
-    LPARAM coords = MAKELPARAM(screen_loc.x(), screen_loc.y());
+    LPARAM coords = MAKELPARAM(screen_loc_pixels.x(), screen_loc_pixels.y());
     LRESULT nc_hit_result = SendMessage(target_window, WM_NCHITTEST, 0, coords);
     const bool client_area = nc_hit_result == HTCLIENT;
 
     // TODO(sky): this isn't right. The event to generate should correspond with
     // the event we just got. MouseEvent only tells us what is down, which may
     // differ. Need to add ability to get changed button from MouseEvent.
     int event_type;
     int flags = event.flags();
     if (flags & ui::EF_LEFT_MOUSE_BUTTON) {
       event_type = client_area ? WM_LBUTTONDOWN : WM_NCLBUTTONDOWN;
     } else if (flags & ui::EF_MIDDLE_MOUSE_BUTTON) {
       event_type = client_area ? WM_MBUTTONDOWN : WM_NCMBUTTONDOWN;
     } else if (flags & ui::EF_RIGHT_MOUSE_BUTTON) {
       event_type = client_area ? WM_RBUTTONDOWN : WM_NCRBUTTONDOWN;
     } else {
       NOTREACHED();
       return;
     }
 
-    int window_x = screen_loc.x();
-    int window_y = screen_loc.y();
+    int window_x = screen_loc_pixels.x();
+    int window_y = screen_loc_pixels.y();
     if (client_area) {
       POINT pt = { window_x, window_y };
       ScreenToClient(target_window, &pt);
       window_x = pt.x;
       window_y = pt.y;
     }
 
     WPARAM target = client_area ? event.native_event().wParam : nc_hit_result;
     LPARAM window_coords = MAKELPARAM(window_x, window_y);
     PostMessage(target_window, event_type, target, window_coords);
@@ skipping 181 matching lines @@
   }
 }
 
 gfx::Screen* MenuController::GetScreen() {
   Widget* root = owner_ ? owner_->GetTopLevelWidget() : NULL;
   return root ? gfx::Screen::GetScreenFor(root->GetNativeView())
               : gfx::Screen::GetNativeScreen();
 }
 
 }  // namespace views