views: Fix painting text over old avatar menu button.

views: Fix painting text over old avatar menu button.

We were setting text on the button, but that text was ignored previously by overriding OnPaint(). Now just get rid of it.

BUG=385934

[msw, 2014-06-18 00:29:38]

lgtm with a nit, presuming this doesn't break the new profile management
button's text. CC'ing a few people for heads up.

https://codereview.chromium.org/341733002/diff/1/chrome/browser/ui/views/fram...
File chrome/browser/ui/views/frame/browser_non_client_frame_view.cc (right):

https://codereview.chromium.org/341733002/diff/1/chrome/browser/ui/views/fram...
chrome/browser/ui/views/frame/browser_non_client_frame_view.cc:124: if
(avatar_button_) {
nit: you could remove these curly braces.

[Elliot Glaysher, 2014-06-18 00:34:16]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-06-18 00:37:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erg@chromium.org/341733002/10002

[commit-bot: I haz the power, 2014-06-18 14:54:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 14:54:52]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[noms (inactive), 2014-06-18 15:01:49]

--new-profile-management should be fine; that function is only called for the
old style profile avatar. Thanks Mike & Elliot!

[Elliot Glaysher, 2014-06-18 18:14:06]

This patch is superseded by https://codereview.chromium.org/344643002/ . I have
rolled it into the reland of the patch which broke this in the first place.