Refactored StringToIntEnumListPolicyHandler to be more general purpose

Refactored StringToIntEnumListPolicyHandler to be more general purpose

Created new StringMappingListPolicyHandler class to provide general
mapping between policy string lists and generic pref types (int lists,
string lists, etc).

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278083

[Andrew T Wilson (Slow), 2014-06-18 05:53:43]

Finally got around to that refactoring of ConfigurationPolicyHandler we
discussed last week. PTAL.

[Joao da Silva, 2014-06-18 08:45:26]

lgtm with a couple of nits

https://codereview.chromium.org/341723002/diff/60001/chrome/browser/policy/co...
File chrome/browser/policy/configuration_policy_handler_list_factory.cc (right):

https://codereview.chromium.org/341723002/diff/60001/chrome/browser/policy/co...
chrome/browser/policy/configuration_policy_handler_list_factory.cc:507:
"platform_app", scoped_ptr<base::Value>(base::Value::CreateIntegerValue(
CreateIntegerValue is deprecated, use new base::FundamentalValue(n)

https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
File components/policy/core/browser/configuration_policy_handler.cc (right):

https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
components/policy/core/browser/configuration_policy_handler.cc:158: :
enum_value(policy_value), mapped_value(map.release()) {}
.release() works but I think it's more common to do .Pass() to move from
scoped_ptr to scoped_ptr

https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
File components/policy/core/browser/configuration_policy_handler.h (right):

https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
components/policy/core/browser/configuration_policy_handler.h:184:
GenerateMapCallback map_generator);
pass by const&

https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
File components/policy/core/browser/configuration_policy_handler_unittest.cc
(right):

https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
components/policy/core/browser/configuration_policy_handler_unittest.cc:26:
"two", scoped_ptr<base::Value>(base::Value::CreateIntegerValue(2))));
CreateIntegerValue() is deprecated, use new base::FundamentalValue(n) instead

[Andrew T Wilson (Slow), 2014-06-18 11:10:00]

The CQ bit was checked by atwilson@chromium.org

[commit-bot: I haz the power, 2014-06-18 11:11:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/atwilson@chromium.org/341723002/80001

[Andrew T Wilson (Slow), 2014-06-18 11:11:38]

On 2014/06/18 08:45:26, Joao da Silva wrote:
> lgtm with a couple of nits
> 
>
https://codereview.chromium.org/341723002/diff/60001/chrome/browser/policy/co...
> File chrome/browser/policy/configuration_policy_handler_list_factory.cc
(right):
> 
>
https://codereview.chromium.org/341723002/diff/60001/chrome/browser/policy/co...
> chrome/browser/policy/configuration_policy_handler_list_factory.cc:507:
> "platform_app", scoped_ptr<base::Value>(base::Value::CreateIntegerValue(
> CreateIntegerValue is deprecated, use new base::FundamentalValue(n)
> 
>
https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
> File components/policy/core/browser/configuration_policy_handler.cc (right):
> 
>
https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
> components/policy/core/browser/configuration_policy_handler.cc:158: :
> enum_value(policy_value), mapped_value(map.release()) {}
> .release() works but I think it's more common to do .Pass() to move from
> scoped_ptr to scoped_ptr
> 
>
https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
> File components/policy/core/browser/configuration_policy_handler.h (right):
> 
>
https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
> components/policy/core/browser/configuration_policy_handler.h:184:
> GenerateMapCallback map_generator);
> pass by const&
> 
>
https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
> File components/policy/core/browser/configuration_policy_handler_unittest.cc
> (right):
> 
>
https://codereview.chromium.org/341723002/diff/60001/components/policy/core/b...
> components/policy/core/browser/configuration_policy_handler_unittest.cc:26:
> "two", scoped_ptr<base::Value>(base::Value::CreateIntegerValue(2))));
> CreateIntegerValue() is deprecated, use new base::FundamentalValue(n) instead

I missed a couple uses of CreateIntegerValue. I'll fix those in my next cl.

[commit-bot: I haz the power, 2014-06-18 15:25:03]

Change committed as 278083