Use weak pointer to where possible

chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_LOGIN_USERS_WALLPAPER_WALLPAPER_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_LOGIN_USERS_WALLPAPER_WALLPAPER_MANAGER_H_
 
 #include <deque>
 #include <string>
 #include <vector>
@@ skipping 205 matching lines @@
   static bool ResizeAndSaveWallpaper(const gfx::ImageSkia& image,
                                      const base::FilePath& path,
                                      ash::WallpaperLayout layout,
                                      int preferred_width,
                                      int preferred_height,
                                      gfx::ImageSkia* output_skia);
 
   // Returns the appropriate wallpaper resolution for all root windows.
   static WallpaperResolution GetAppropriateResolution();
 
+  // Returns custom wallpaper path. Append |sub_dir|, |user_id_hash| and |file|
+  // to custom wallpaper directory.
+  static base::FilePath GetCustomWallpaperPath(const char* sub_dir,
+                                               const std::string& user_id_hash,
+                                               const std::string& file);
+
   void SetCommandLineForTesting(base::CommandLine* command_line);
 
   // Indicates imminent shutdown, allowing the WallpaperManager to remove any
   // observers it has registered.
   void Shutdown();
 
   // Adds PowerManagerClient, TimeZoneSettings and CrosSettings observers.
   void AddObservers();
 
   // Loads wallpaper asynchronously if the current wallpaper is not the
   // wallpaper of logged in user.
   void EnsureLoggedInUserWallpaperLoaded();
 
-  // Returns custom wallpaper path. Append |sub_dir|, |user_id_hash| and |file|
-  // to custom wallpaper directory.
-  base::FilePath GetCustomWallpaperPath(const char* sub_dir,
-                                        const std::string& user_id_hash,
-                                        const std::string& file) const;
-
   // Gets wallpaper information of logged in user.
   bool GetLoggedInUserWallpaperInfo(WallpaperInfo* info);
 
   // Initializes wallpaper. If logged in, loads user's wallpaper. If not logged
   // in, uses a solid color wallpaper. If logged in as a stub user, uses an
   // empty wallpaper.
   void InitializeWallpaper();
 
   // NotificationObserver overrides:
   virtual void Observe(int type,
@@ skipping 81 matching lines @@
   // must be writable.
   void SetCustomizedDefaultWallpaper(const GURL& wallpaper_url,
                                      const base::FilePath& downloaded_file,
                                      const base::FilePath& resized_directory);
 
   // Returns queue size.
   size_t GetPendingListSizeForTesting() const;
 
  private:
   friend class TestApi;
+  friend class PendingWallpaper;
   friend class WallpaperManagerBrowserTest;
   friend class WallpaperManagerBrowserTestDefaultWallpaper;
   friend class WallpaperManagerPolicyTest;
 
   typedef std::map<std::string, gfx::ImageSkia> CustomWallpaperMap;
 
+
+  // Record data for User Metrics Analysis.
+  static void RecordUma(User::WallpaperType type, int index);
+
+  // Saves original custom wallpaper to |path| (absolute path) on filesystem
+  // and starts resizing operation of the custom wallpaper if necessary.
+  static void SaveCustomWallpaper(const std::string& user_id_hash,
+                                  const base::FilePath& path,
+                                  ash::WallpaperLayout layout,
+                                  scoped_ptr<gfx::ImageSkia> image);
+
+  // Moves custom wallpapers from |user_id| directory to |user_id_hash|
+  // directory.
+  static void MoveCustomWallpapersOnWorker(
+      const std::string& user_id,
+      const std::string& user_id_hash,
+      base::WeakPtr<WallpaperManager> weak_ptr);
+
+  // Gets |user_id|'s custom wallpaper at |wallpaper_path|. Falls back on
+  // original custom wallpaper. When |update_wallpaper| is true, sets wallpaper
+  // to the loaded wallpaper. Must run on wallpaper sequenced worker thread.
+  static void GetCustomWallpaperInternal(
+      const std::string& user_id,
+      const WallpaperInfo& info,
+      const base::FilePath& wallpaper_path,
+      bool update_wallpaper,
+      MovableOnDestroyCallbackHolder on_finish,
+      base::WeakPtr<WallpaperManager> weak_ptr);
+
+  // Resize and save customized default wallpaper.
+  static void ResizeCustomizedDefaultWallpaper(
+      scoped_ptr<gfx::ImageSkia> image,
+      const UserImage::RawImage& raw_image,
+      const CustomizedWallpaperRescaledFiles* rescaled_files,
+      bool* success,
+      gfx::ImageSkia* small_wallpaper_image,
+      gfx::ImageSkia* large_wallpaper_image);
+
   // Initialize wallpaper for the specified user to default and saves this
   // settings in local state.
   void InitInitialUserWallpaper(const std::string& user_id, bool is_persistent);
 
   // Set wallpaper to |user_image| controlled by policy.  (Takes a UserImage
   // because that's the callback interface provided by UserImageLoader.)
   void SetPolicyControlledWallpaper(const std::string& user_id,
                                     const UserImage& user_image);
 
   // Gets encoded wallpaper from cache. Returns true if success.
@@ skipping 35 matching lines @@
   // Note that before device is enrolled, it proceeds with untrusted setting.
   void InitializeRegisteredDeviceWallpaper();
 
   // Loads |user_id|'s wallpaper. When |update_wallpaper| is true, sets
   // wallpaper to the loaded wallpaper.
   void LoadWallpaper(const std::string& user_id,
                      const WallpaperInfo& info,
                      bool update_wallpaper,
                      MovableOnDestroyCallbackHolder on_finish);
 
-  // Moves custom wallpapers from |user_id| directory to |user_id_hash|
-  // directory.
-  void MoveCustomWallpapersOnWorker(const std::string& user_id,
-                                    const std::string& user_id_hash);
-
   // Called when the original custom wallpaper is moved to the new place.
   // Updates the corresponding user wallpaper info.
   void MoveCustomWallpapersSuccess(const std::string& user_id,
                                    const std::string& user_id_hash);
 
   // Moves custom wallpaper to a new place. Email address was used as directory
   // name in the old system, this is not safe. New directory system uses
   // user_id_hash instead of user_id. This must be called after user_id_hash is
   // ready.
   void MoveLoggedInUserCustomWallpaper();
 
-  // Gets |user_id|'s custom wallpaper at |wallpaper_path|. Falls back on
-  // original custom wallpaper. When |update_wallpaper| is true, sets wallpaper
-  // to the loaded wallpaper. Must run on wallpaper sequenced worker thread.
-  void GetCustomWallpaperInternal(const std::string& user_id,
-                                  const WallpaperInfo& info,
-                                  const base::FilePath& wallpaper_path,
-                                  bool update_wallpaper,
-                                  MovableOnDestroyCallbackHolder on_finish);
-
   // Gets wallpaper information of |user_id| from Local State or memory. Returns
   // false if wallpaper information is not found.
   bool GetUserWallpaperInfo(const std::string& user_id,
                             WallpaperInfo* info) const;
 
   // Sets wallpaper to the decoded wallpaper if |update_wallpaper| is true.
   // Otherwise, cache wallpaper to memory if not logged in.  (Takes a UserImage
   // because that's the callback interface provided by UserImageLoader.)
   void OnWallpaperDecoded(const std::string& user_id,
                           ash::WallpaperLayout layout,
                           bool update_wallpaper,
                           MovableOnDestroyCallbackHolder on_finish,
                           const UserImage& user_image);
 
-  // Record data for User Metrics Analysis.
-  void RecordUma(User::WallpaperType type, int index) const;
-
-  // Saves original custom wallpaper to |path| (absolute path) on filesystem
-  // and starts resizing operation of the custom wallpaper if necessary.
-  void SaveCustomWallpaper(const std::string& user_id_hash,
-                           const base::FilePath& path,
-                           ash::WallpaperLayout layout,
-                           scoped_ptr<gfx::ImageSkia> image) const;
-
   // Creates new PendingWallpaper request (or updates currently pending).
   void ScheduleSetUserWallpaper(const std::string& user_id, bool delayed);
 
   // Sets wallpaper to default.
   void DoSetDefaultWallpaper(
       const std::string& user_id,
       MovableOnDestroyCallbackHolder on_finish);
 
   // Starts to load wallpaper at |wallpaper_path|. If |wallpaper_path| is the
   // same as |current_wallpaper_path_|, do nothing. Must be called on UI thread.
@@ skipping 29 matching lines @@
       const GURL& wallpaper_url,
       const base::FilePath& downloaded_file,
       scoped_ptr<CustomizedWallpaperRescaledFiles> rescaled_files);
 
   // Starts rescaling of customized wallpaper.
   void OnCustomizedDefaultWallpaperDecoded(
       const GURL& wallpaper_url,
       scoped_ptr<CustomizedWallpaperRescaledFiles> rescaled_files,
       const UserImage& user_image);
 
-  // Resize and save customized default wallpaper.
-  void ResizeCustomizedDefaultWallpaper(
-      scoped_ptr<gfx::ImageSkia> image,
-      const UserImage::RawImage& raw_image,
-      const CustomizedWallpaperRescaledFiles* rescaled_files,
-      bool* success,
-      gfx::ImageSkia* small_wallpaper_image,
-      gfx::ImageSkia* large_wallpaper_image);
-
   // Check the result of ResizeCustomizedDefaultWallpaper and finally
   // apply Customized Default Wallpaper.
   void OnCustomizedDefaultWallpaperResized(
       const GURL& wallpaper_url,
       scoped_ptr<CustomizedWallpaperRescaledFiles> rescaled_files,
       scoped_ptr<bool> success,
       scoped_ptr<gfx::ImageSkia> small_wallpaper_image,
       scoped_ptr<gfx::ImageSkia> large_wallpaper_image);
 
   // Init |*default_*_wallpaper_file_| from given command line and
@@ skipping 83 matching lines @@
 
   // Current decoded default image is stored in cache.
   scoped_ptr<UserImage> default_wallpaper_image_;
 
   DISALLOW_COPY_AND_ASSIGN(WallpaperManager);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_LOGIN_USERS_WALLPAPER_WALLPAPER_MANAGER_H_