Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 341713003: ThreadWatcher: disarm startup watchdog even when stop is called. (Closed)

Created:
6 years, 6 months ago by bulach
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

ThreadWatcher: disarm startup watchdog even when stop is called. StopWatchingAll() can be called before InitializeAndStartWatching is called. Before bailing out, disarm the startup watchdog. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277968

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/metrics/thread_watcher.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bulach
thanks for the super useful debugging session, very interesting! :) ptal
6 years, 6 months ago (2014-06-18 00:48:33 UTC) #1
ramant (doing other things)
lgtm
6 years, 6 months ago (2014-06-18 01:07:15 UTC) #2
bulach
The CQ bit was checked by bulach@chromium.org
6 years, 6 months ago (2014-06-18 01:08:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/341713003/1
6 years, 6 months ago (2014-06-18 01:11:29 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 07:22:19 UTC) #5
Message was sent while issue was closed.
Change committed as 277968

Powered by Google App Engine
This is Rietveld 408576698