Make App Info Dialog file permissions middle elided

Make App Info Dialog file permissions middle elided

Update the list of file permissions in the App Info dialog to elide in
the middle, to better match the UI mocks of the dialog.

Screenshots on bug.

BUG=385978
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278395

[sashab, 2014-06-18 22:14:38]

Small & low priority.

[benwells, 2014-06-19 01:04:39]

https://codereview.chromium.org/341703003/diff/1/chrome/browser/ui/views/apps...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
(right):

https://codereview.chromium.org/341703003/diff/1/chrome/browser/ui/views/apps...
chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc:59:
bool add_middle_ellipses) {
If you make this take a ElideBehavior instead of a bool, code calling it would
be more readable and the function would be more flexible.

https://codereview.chromium.org/341703003/diff/1/chrome/browser/ui/views/apps...
chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc:70:
permission_label->SetElideBehavior(gfx::ElideBehavior::ELIDE_MIDDLE);
Just gfx::ELIDE_MIDDLE.

[sashab, 2014-06-19 04:34:25]

Code readability/understandability is really difficult :)

https://codereview.chromium.org/341703003/diff/1/chrome/browser/ui/views/apps...
File chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc
(right):

https://codereview.chromium.org/341703003/diff/1/chrome/browser/ui/views/apps...
chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc:59:
bool add_middle_ellipses) {
On 2014/06/19 01:04:38, benwells wrote:
> If you make this take a ElideBehavior instead of a bool, code calling it would
> be more readable and the function would be more flexible.

I thought of doing that, but how would you specify 'do not elide'? I'd have to
add a special case where ElideBehavior::TRUNCATE actually means 'multiline'.

Separated into two parameters for now.

https://codereview.chromium.org/341703003/diff/1/chrome/browser/ui/views/apps...
chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.cc:70:
permission_label->SetElideBehavior(gfx::ElideBehavior::ELIDE_MIDDLE);
On 2014/06/19 01:04:38, benwells wrote:
> Just gfx::ELIDE_MIDDLE.

Done.

[sashab, 2014-06-19 04:34:25]

Code readability/understandability is really difficult :)

[benwells, 2014-06-19 06:34:00]

ah ok. I assumed there was ELIDE_NONE.

lgtm like this or like it was.

[sashab, 2014-06-19 07:40:20]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-06-19 07:41:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sashab@chromium.org/341703003/20001

[commit-bot: I haz the power, 2014-06-19 16:18:51]

Change committed as 278395