Issue 341693004: Fix Desktop.dispatchKeyEvent() to return correct result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341693004: Fix Desktop.dispatchKeyEvent() to return correct result. (Closed)

Created:
6 years, 6 months ago by Sergey Ulanov

Modified:
6 years, 6 months ago

Reviewers:
Lambros

CC:
chromium-reviews, chromoting-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix Desktop.dispatchKeyEvent() to return correct result. Previously Desktop.dispatchKeyEvent() was sending keyboard events to the host and then pretending that it didn't handle the event. Now it returns correct result telling the caller when the event was handled. BUG=385972 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278331

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -31 lines)			Patch
M	remoting/android/java/src/org/chromium/chromoting/Desktop.java	View	1 chunk	+7 lines, -9 lines	0 comments	Download
M	remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	remoting/client/jni/chromoting_jni_instance.h	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	remoting/client/jni/chromoting_jni_instance.cc	View	2 chunks	+23 lines, -15 lines	0 comments	Download
M	remoting/client/jni/chromoting_jni_runtime.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/341693004/1

6 years, 6 months ago (2014-06-19 01:20:39 UTC) #4

Message was sent while issue was closed.

Change committed as 278331

Expand Messages | Collapse Messages