Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 341683002: Add ss/sd suffix to InstX8632Store and legalize FP constants. (Closed)

Created:
6 years, 6 months ago by jvoung (off chromium)
Modified:
6 years, 6 months ago
Reviewers:
Jim Stichnoth, wala
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Add ss/sd suffix to InstX8632Store and legalize FP constants. InstX8632Store is essentially a "mov" and it would emit a mov, but it did not add the ss/sd suffix based on the operand type. Also, there are some cases where legalization would leave two memory operands in the case that one of them is a floating point immediate: storeDoubleConst: .LstoreDoubleConst$entry: mov eax, dword ptr [esp+4] mov qword ptr [eax], qword ptr [L$double$1] ret BUG=none R=stichnot@chromium.org, wala@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=5a13f45

Patch Set 1 #

Patch Set 2 : another label #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -109 lines) Patch
M src/IceInstX8632.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 1 chunk +5 lines, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 1 100 chunks +109 lines, -107 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvoung (off chromium)
6 years, 6 months ago (2014-06-17 22:51:12 UTC) #1
Jim Stichnoth
lgtm
6 years, 6 months ago (2014-06-17 23:53:57 UTC) #2
wala
lgtm
6 years, 6 months ago (2014-06-18 00:57:10 UTC) #3
jvoung (off chromium)
6 years, 6 months ago (2014-06-18 17:42:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r5a13f45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698