gcl.py - Issue 341663004: Do not notify watchers about --private issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gcl.py

Issue 341663004: Do not notify watchers about --private issues (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gcl.py

diff --git a/gcl.py b/gcl.py

index 775ab94dd6ce9d346749bfa987c3a00be6b99b83..1502c061effe99e4b16cf2c2a0de0bd384f1ad4b 100755

--- a/gcl.py

+++ b/gcl.py

@@ -896,9 +896,11 @@ def CMDupload(change_info, args):

# CC_LIST only when --private is specified explicitly on the command

# line.

if "--private" in upload_arg:

- Warn("WARNING: CC_LIST is ignored since private flag is specified. "

- "You need to review and add them manually if necessary.")

+ Warn("WARNING: CC_LIST and WATCHLISTS are ignored when --private is "

+ "specified. You need to review and add them manually if "

+ "necessary.")

cc_list = ""

+ no_watchlists = True

else:

cc_list = GetCodeReviewSetting("CC_LIST")

if not no_watchlists and watchers:

« no previous file with comments | « no previous file | no next file » | no next file with comments »