Issue 341663004: Do not notify watchers about --private issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341663004: Do not notify watchers about --private issues (Closed)

Created:
6 years, 6 months ago by jrobbins

Modified:
6 years, 6 months ago

Reviewers:
cmp, Jason Robbins -- corp, iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Do not notify watchers about --private issues BUG=382297 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=278484

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	gcl.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jason Robbins -- corp

The CQ bit was checked by jrobbins@google.com

6 years, 6 months ago (2014-06-19 21:09:47 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrobbins@chromium.org/341663004/1

6 years, 6 months ago (2014-06-19 21:10:02 UTC) #4

Jason Robbins -- corp

6 years, 5 months ago (2014-07-24 01:55:47 UTC) #6

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/418803002/ by jrobbins@google.com.

The reason for reverting is: just testing revert, I will not really revert..

Expand Messages | Collapse Messages