Issue 341653003: Add linker dependency on advapi32.lib for icuuc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341653003: Add linker dependency on advapi32.lib for icuuc (Closed)

Created:
6 years, 6 months ago by jungshik at Google

Modified:
6 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/third_party/icu52/

Visibility:
Public.

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	icu.gyp	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

jungshik at Google

John, this is just applying your CL to icu4.6.1 to icu52. BTW, what's the symptom ...

6 years, 6 months ago (2014-06-17 22:25:49 UTC) #1

jam

lgtm On 2014/06/17 22:25:49, Jungshik Shin wrote: > John, this is just applying your CL ...

6 years, 6 months ago (2014-06-18 00:40:44 UTC) #2

jungshik at Google

6 years, 6 months ago (2014-06-18 09:33:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r277999 (presubmit successful).