Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 341653002: Remove vestigal SDCH stuff in IOThread. (Closed)

Created:
6 years, 6 months ago by Randy Smith (Not in Mondays)
Modified:
6 years, 6 months ago
Reviewers:
mef, sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove vestigal SDCH stuff in IOThread. (It was missed on initial profile refactor.) BUG=374914 R=mef@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278183

Patch Set 1 #

Patch Set 2 : Remove class forward decl. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M chrome/browser/io_thread.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/io_thread.cc View 5 chunks +0 lines, -11 lines 2 comments Download

Messages

Total messages: 8 (0 generated)
Randy Smith (Not in Mondays)
Misha, willing to give me a quick review? I missed this stuff on the initial ...
6 years, 6 months ago (2014-06-18 13:20:15 UTC) #1
mef
lgtm https://codereview.chromium.org/341653002/diff/20001/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (left): https://codereview.chromium.org/341653002/diff/20001/chrome/browser/io_thread.cc#oldcode1063 chrome/browser/io_thread.cc:1063: new SdchDictionaryFetcher( So, where is fetcher now?
6 years, 6 months ago (2014-06-18 17:30:30 UTC) #2
Randy Smith (Not in Mondays)
Scott, another stamp? https://codereview.chromium.org/341653002/diff/20001/chrome/browser/io_thread.cc File chrome/browser/io_thread.cc (left): https://codereview.chromium.org/341653002/diff/20001/chrome/browser/io_thread.cc#oldcode1063 chrome/browser/io_thread.cc:1063: new SdchDictionaryFetcher( On 2014/06/18 17:30:30, mef ...
6 years, 6 months ago (2014-06-18 17:39:26 UTC) #3
sky
LGTM - feel free to TBR this sort of stuff.
6 years, 6 months ago (2014-06-18 21:15:45 UTC) #4
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org
6 years, 6 months ago (2014-06-18 21:18:04 UTC) #5
Randy Smith (Not in Mondays)
Fair. Thanks!
6 years, 6 months ago (2014-06-18 21:18:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/341653002/20001
6 years, 6 months ago (2014-06-18 21:18:52 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 22:08:25 UTC) #8
Message was sent while issue was closed.
Change committed as 278183

Powered by Google App Engine
This is Rietveld 408576698