Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 341643004: Updating keyboard overlay for previous/next user in multi profile mode (Closed)

Created:
6 years, 6 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 6 months ago
Reviewers:
James Cook, sky
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Updating keyboard overlay for previous/next user in multi profile mode I updated our keyboard mapping sheets and used the python scripts to generate the changes. BUG=325792 TEST=visual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay_data.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 6 months ago (2014-06-17 22:54:43 UTC) #1
James Cook
lgtm
6 years, 6 months ago (2014-06-17 23:21:00 UTC) #2
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 6 months ago (2014-06-17 23:24:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/341643004/1
6 years, 6 months ago (2014-06-17 23:27:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-18 05:36:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/74454)
6 years, 6 months ago (2014-06-18 05:36:22 UTC) #6
Mr4D (OOO till 08-26)
Zel, can I ask you for an owners review? Thanks!
6 years, 6 months ago (2014-06-18 15:26:16 UTC) #7
Mr4D (OOO till 08-26)
Sky, can you please do an owners review? Thanks!
6 years, 6 months ago (2014-06-20 16:47:16 UTC) #8
sky
LGTM
6 years, 6 months ago (2014-06-20 16:50:02 UTC) #9
Mr4D (OOO till 08-26)
The CQ bit was checked by skuhne@chromium.org
6 years, 6 months ago (2014-06-20 16:50:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/341643004/1
6 years, 6 months ago (2014-06-20 16:53:31 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 17:06:21 UTC) #12
Message was sent while issue was closed.
Change committed as 278730

Powered by Google App Engine
This is Rietveld 408576698