Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 341633002: declare dependency on ui/gfx since jni_frame_consumer.cc includes from it (Closed)

Created:
6 years, 6 months ago by reed1
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org, bungeman-chromium
Project:
chromium
Visibility:
Public.

Description

declare dependency on ui/gfx since jni_frame_consumer.cc includes from it This is especially needed because ui/gfx headers, in turn, can include skia headers, which are only meaningful in the context of skia's compile flags. Those are available from ui/gfx since it re-exports skia's dependencies. Landing tbr to unblock skia's DEPS roll. TBR=lambros@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277926

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M remoting/remoting_android.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
reed1
need OWNER review to unblock skia DEPS roll
6 years, 6 months ago (2014-06-17 19:51:10 UTC) #1
reed1
Here is the try-bot that failed due to the missing dependency http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/152851/steps/compile/logs/stdio In file included ...
6 years, 6 months ago (2014-06-17 19:55:56 UTC) #2
reed1
6 years, 6 months ago (2014-06-17 20:04:13 UTC) #3
reed1
The CQ bit was checked by reed@google.com
6 years, 6 months ago (2014-06-17 20:33:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reed@google.com/341633002/1
6 years, 6 months ago (2014-06-17 20:34:32 UTC) #5
commit-bot: I haz the power
Change committed as 277926
6 years, 6 months ago (2014-06-18 00:37:41 UTC) #6
Lambros
6 years, 6 months ago (2014-06-18 00:57:32 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698