Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Issue 341623002: Force resetting the VK insets when overscroll mode is disabled. (Closed)

Created:
6 years, 6 months ago by kevers
Modified:
6 years, 6 months ago
Reviewers:
bshe
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Force resetting the VK insets when overscroll mode is disabled. The login and lock screens can toggle overscroll mode for the virtual keyboard without triggering a rebuild of the VK. Thus, it is possible to be in an inconsistent state between keyboard bounds change notifications. This patch forces any insets to be reset if overscroll mode is not enabled. BUG=384981 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277961

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/keyboard/keyboard_controller.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kevers
Hi Biao, Can you please take a look at this CL.
6 years, 6 months ago (2014-06-17 18:44:14 UTC) #1
bshe
On 2014/06/17 18:44:14, kevers wrote: > Hi Biao, > > Can you please take a ...
6 years, 6 months ago (2014-06-17 19:23:55 UTC) #2
kevers
The CQ bit was checked by kevers@chromium.org
6 years, 6 months ago (2014-06-17 20:15:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/341623002/1
6 years, 6 months ago (2014-06-17 20:18:43 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-18 07:03:18 UTC) #5
Message was sent while issue was closed.
Change committed as 277961

Powered by Google App Engine
This is Rietveld 408576698