Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 341583004: Use stub implementations for get{e,}[ug]id (Closed)

Created:
6 years, 6 months ago by Roland McGrath
Modified:
6 years, 6 months ago
Reviewers:
David Yen
CC:
native-client-reviews_googlegroups.com, Mark Seaborn
Base URL:
http://git.chromium.org/native_client/nacl-glibc.git@master
Visibility:
Public.

Description

Use stub implementations for get{e,}[ug]id These functions are unusable stubs today, indirectly via the kludges that replace the syscall macros and stubs. But on x86-32 they wind up as stubs that return 0 (false success) whereas on x86-64 they fail with ENOSYS. In neither case are they properly marked as stubs so as to generate linker warnings, though in neither case is there any mechanism by which they could be made to do anything different. Instead, just always use the basic stub implementations that uniformly fail with ENOSYS and generate linker warnings. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3667 TEST= toolchain trybots R=dyen@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=9b15f6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M make_sysd_rules.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Roland McGrath
6 years, 6 months ago (2014-06-17 21:10:06 UTC) #1
David Yen
lgtm
6 years, 6 months ago (2014-06-18 18:19:06 UTC) #2
Roland McGrath
6 years, 6 months ago (2014-06-18 18:41:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r9b15f6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698