[Android] Allow Disconnected RVH to suspend the shared timer.

[Android] Allow Disconnected RVH to suspend the shared timer.

For backwards compatibility in the Android WebView, it should be
possible to pause the shared timer before the WebView has been
navigated, the net effect being the initial navigation takes place
with the timer suspended.

This was introduced by http://src.chromium.org/viewvc/chrome?view=revision&revision=256153

BUG=321610
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278239

[benm (inactive), 2014-06-17 21:31:12]

ptal Yaron

[Yaron, 2014-06-18 00:41:17]

https://codereview.chromium.org/341583003/diff/1/content/browser/android/cont...
File content/browser/android/content_view_statics.cc (left):

https://codereview.chromium.org/341583003/diff/1/content/browser/android/cont...
content/browser/android/content_view_statics.cc:63: if (host->HasConnection()) {
This was done per Grace's comment:
https://codereview.chromium.org/179123002/diff/80001/content/browser/android/...

I couldn't think of a reason for suspending prior to it navigating. What happens
if you also get a resume before the webview is navigated? Presumably both
messages are queue and it sitll works?

[benm (inactive), 2014-06-18 13:17:30]

On 2014/06/18 00:41:17, Yaron wrote:
>
https://codereview.chromium.org/341583003/diff/1/content/browser/android/cont...
> File content/browser/android/content_view_statics.cc (left):
> 
>
https://codereview.chromium.org/341583003/diff/1/content/browser/android/cont...
> content/browser/android/content_view_statics.cc:63: if (host->HasConnection())
{
> This was done per Grace's comment:
>
https://codereview.chromium.org/179123002/diff/80001/content/browser/android/...
> 
> I couldn't think of a reason for suspending prior to it navigating. What
happens
> if you also get a resume before the webview is navigated? Presumably both
> messages are queue and it sitll works?

Yes, exactly right.

[Yaron, 2014-06-18 18:10:30]

On 2014/06/18 13:17:30, benm_OOO_to_17June wrote:
> On 2014/06/18 00:41:17, Yaron wrote:
> >
>
https://codereview.chromium.org/341583003/diff/1/content/browser/android/cont...
> > File content/browser/android/content_view_statics.cc (left):
> > 
> >
>
https://codereview.chromium.org/341583003/diff/1/content/browser/android/cont...
> > content/browser/android/content_view_statics.cc:63: if
(host->HasConnection())
> {
> > This was done per Grace's comment:
> >
>
https://codereview.chromium.org/179123002/diff/80001/content/browser/android/...
> > 
> > I couldn't think of a reason for suspending prior to it navigating. What
> happens
> > if you also get a resume before the webview is navigated? Presumably both
> > messages are queue and it sitll works?
> 
> Yes, exactly right.

lgtm

[benm (inactive), 2014-06-18 18:13:17]

The CQ bit was checked by benm@chromium.org

[commit-bot: I haz the power, 2014-06-18 18:14:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benm@chromium.org/341583003/1

[commit-bot: I haz the power, 2014-06-19 01:53:10]

Change committed as 278239