Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
341573003:
Don't remove -m32 when building ia32 targets. (Closed)
|
Created:
6 years, 6 months ago by Nico Modified:
6 years, 6 months ago CC:
native-client-reviews_googlegroups.com Visibility:
Public. |
DescriptionDon't remove -m32 when building ia32 targets.
There used to be a host_arch conditional that got lost when munge_phdr moved
from chromium to nacl, see
https://codereview.chromium.org/8800034/diff/4001/chrome/nacl.gypi
https://codereview.chromium.org/8623002/diff/10001/src/trusted/service_runtime/linux/nacl_bootstrap.gyp
Keeping the -m32 flag when target_arch and host_arch are both ia32 is important
when building with a 32bit userspace on a 64bit kernel using a 64bit clang
binary as compiler.
As far as I can tell, -m32 and -sysroot are only added for target binaries,
so this hack shouldn't be necesesary anymore. (And if it turns out that it
still is for some reason, that reason can likely be fixed instead.)
(Somewhat related to https://codereview.chromium.org/342493002/)
BUG=368384
R=bradnelson@google.com
Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13369
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 23 (0 generated)
+Brad, as it removes a TODO for him :-)
+dyen David might recall differently, but I think this is fine. lgtm
Rubber-stamp LGTM Was that hack there because we used to support building Chromium with x86-32 multilib libraries installed on a mainly-x86-64 system? That got broken with Ubuntu Precise (which doesn't have enough multilib libraries), and so building for x86-32 Linux requires at least a chroot, which sounds like your use case?
On Tue, Jun 17, 2014 at 5:07 PM, <mseaborn@chromium.org> wrote: > Rubber-stamp LGTM > > Was that hack there because we used to support building Chromium with > x86-32 > multilib libraries installed on a mainly-x86-64 system? That got broken > with > Ubuntu Precise (which doesn't have enough multilib libraries), and so > building > for x86-32 Linux requires at least a chroot, which sounds like your use > case? > Yup. > > https://codereview.chromium.org/341573003/ > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
(But if multilib still existed, I believe it should be possible to get that working without this hack.) Thanks! On Tue, Jun 17, 2014 at 5:09 PM, Nico Weber <thakis@chromium.org> wrote: > On Tue, Jun 17, 2014 at 5:07 PM, <mseaborn@chromium.org> wrote: > >> Rubber-stamp LGTM >> >> Was that hack there because we used to support building Chromium with >> x86-32 >> multilib libraries installed on a mainly-x86-64 system? That got broken >> with >> Ubuntu Precise (which doesn't have enough multilib libraries), and so >> building >> for x86-32 Linux requires at least a chroot, which sounds like your use >> case? >> > > Yup. > > >> >> https://codereview.chromium.org/341573003/ >> > > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
Message was sent while issue was closed.
Committed patchset #2 manually as r13369 (presubmit successful).
This broke the tree: https://mail.google.com/mail/u/0/?ui=2#inbox/146ac52d19740582?compose=146ac56... Despite a similar sounding tryjob being green: http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_glibc_opt/... Does anyone know why? (I'll revert this for now) On Tue, Jun 17, 2014 at 5:10 PM, <thakis@chromium.org> wrote: > Committed patchset #2 manually as r13369 (presubmit successful). > > https://codereview.chromium.org/341573003/ > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
On 17 June 2014 17:20, Nico Weber <thakis@chromium.org> wrote: > This broke the tree: > https://mail.google.com/mail/u/0/?ui=2#inbox/146ac52d19740582?compose=146ac56... > > Despite a similar sounding tryjob being green: > http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_glibc_opt/... > > Does anyone know why? > > (I'll revert this for now) > The error was: FAILED: cc -pthread -Wl,-z,noexecstack -m32 -o nacl_bootstrap_munge_phdr -Wl,--start-group obj/native_client/src/trusted/service_runtime/linux/nacl_bootstrap_munge_phdr.nacl_bootstrap_munge_phdr.o -Wl,--end-group -lelf -lrt -lpthread /usr/bin/ld: cannot find -lelf (from http://build.chromium.org/p/client.nacl/builders/lucid-32-bare-glibc-opt/buil... ) I think that's because we *are* testing a "32-bit-multilib with otherwise-64-bit-userland" configuration on the main waterfall, but not the trybots. That config works with NaCl's fairly minimal dependencies (I often test it in Scons locally), just not with Chromium's dependencies. We used to have bots that covered that, at least. Brad N might know the details. The error would be because the bot hasn't got a 32-bit multilib version of libelf installed, and before your change it was using the 64-bit version of libelf. Cheers, Mark -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
Message was sent while issue was closed.
On 2014/06/18 00:27:51, Mark Seaborn wrote: > On 17 June 2014 17:20, Nico Weber <mailto:thakis@chromium.org> wrote: > > > This broke the tree: > > > https://mail.google.com/mail/u/0/?ui=2#inbox/146ac52d19740582?compose=146ac56... > > > > Despite a similar sounding tryjob being green: > > > http://build.chromium.org/p/tryserver.nacl/builders/nacl-precise32_glibc_opt/... > > > > Does anyone know why? > > > > (I'll revert this for now) > > > > The error was: > > FAILED: cc -pthread -Wl,-z,noexecstack -m32 -o nacl_bootstrap_munge_phdr > -Wl,--start-group > obj/native_client/src/trusted/service_runtime/linux/nacl_bootstrap_munge_phdr.nacl_bootstrap_munge_phdr.o > -Wl,--end-group -lelf -lrt -lpthread > /usr/bin/ld: cannot find -lelf > > (from > http://build.chromium.org/p/client.nacl/builders/lucid-32-bare-glibc-opt/buil... > ) > > I think that's because we *are* testing a "32-bit-multilib with > otherwise-64-bit-userland" configuration on the main waterfall, but not the > trybots. That config works with NaCl's fairly minimal dependencies (I > often test it in Scons locally), just not with Chromium's dependencies. We > used to have bots that covered that, at least. Brad N might know the > details. > > The error would be because the bot hasn't got a 32-bit multilib version of > libelf installed, and before your change it was using the 64-bit version of > libelf. So http://build.chromium.org/p/client.nacl/builders/precise-32-glibc-dbg/builds/... (which is before my r13367 which made builders build userland bitness instead of kernel bitness – unrelated to this CL) uses -m32, which to me suggests that this bot is a 32bit userland 32bit kernel bot. (I can't check as I don't have ssh access to the bots on the m3 client master.) Is it possible that this bot just doesn't have a 32bit libelf installed, and nobody noticed so far as it wasn't needed on that bot until now?
Message was sent while issue was closed.
On 2014/06/18 19:51:31, Nico (away) wrote: > So > http://build.chromium.org/p/client.nacl/builders/precise-32-glibc-dbg/builds/... > (which is before my r13367 which made builders build userland bitness instead of > kernel bitness – unrelated to this CL) uses -m32, which to me suggests that this > bot is a 32bit userland 32bit kernel bot. (I can't check as I don't have ssh > access to the bots on the m3 client master.) > > Is it possible that this bot just doesn't have a 32bit libelf installed, and > nobody noticed so far as it wasn't needed on that bot until now? I think you misread. The command line for linking nacl_bootstrap_munge_phdr in that log file is: [8/530] cc -pthread -Wl,-z,noexecstack -rdynamic -o nacl_bootstrap_munge_phdr -Wl,--start-group obj/native_client/src/trusted/service_runtime/linux/nacl_bootstrap_munge_phdr.nacl_bootstrap_munge_phdr.o -Wl,--end-group -lelf -lrt -lpthread There is no -m32 in there. vm379-m3 is an x86_64 system (kernel and userland).
On 18 June 2014 12:51, <thakis@chromium.org> wrote: > On 2014/06/18 00:27:51, Mark Seaborn wrote: > > On 17 June 2014 17:20, Nico Weber <mailto:thakis@chromium.org> wrote: >> > > > This broke the tree: >> > >> > > https://mail.google.com/mail/u/0/?ui=2#inbox/146ac52d19740582?compose= > 146ac5672d9f5837 > >> > >> > Despite a similar sounding tryjob being green: >> > >> > > http://build.chromium.org/p/tryserver.nacl/builders/nacl- > precise32_glibc_opt/builds/3131 > >> > >> > Does anyone know why? >> > >> > (I'll revert this for now) >> > >> > > The error was: >> > > FAILED: cc -pthread -Wl,-z,noexecstack -m32 -o nacl_bootstrap_munge_phdr >> -Wl,--start-group >> > > obj/native_client/src/trusted/service_runtime/linux/nacl_ > bootstrap_munge_phdr.nacl_bootstrap_munge_phdr.o > >> -Wl,--end-group -lelf -lrt -lpthread >> /usr/bin/ld: cannot find -lelf >> > > (from >> > > http://build.chromium.org/p/client.nacl/builders/lucid-32- > bare-glibc-opt/builds/6430/steps/gyp_compile/logs/stdio > >> ) >> > > I think that's because we *are* testing a "32-bit-multilib with >> otherwise-64-bit-userland" configuration on the main waterfall, but not >> the >> trybots. That config works with NaCl's fairly minimal dependencies (I >> often test it in Scons locally), just not with Chromium's dependencies. >> We >> used to have bots that covered that, at least. Brad N might know the >> details. >> > > The error would be because the bot hasn't got a 32-bit multilib version of >> libelf installed, and before your change it was using the 64-bit version >> of >> libelf. >> > > > So > http://build.chromium.org/p/client.nacl/builders/precise- > 32-glibc-dbg/builds/1335/steps/gyp_compile/logs/stdio > (which is before my r13367 which made builders build userland bitness > instead of > kernel bitness - unrelated to this CL) uses -m32, which to me suggests > that this > bot is a 32bit userland 32bit kernel bot. (I can't check as I don't have > ssh > access to the bots on the m3 client master.) > If this were running an x86-32 userland, there would be no difference between "cc" and "cc -m32". But when your change switched to "cc -m32", it did give a difference, which is why I don't think it's running a x86-32 userland. This step, in the same buildbot run -- http://build.chromium.org/p/client.nacl/builders/precise-32-glibc-dbg/builds/... -- prints: OS: Linux vm379-m3 3.2.0-55-generic #85-Ubuntu SMP Wed Oct 2 12:29:27 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux This helpfully prints the output of "uname -a" for debugging, which shows that this is running an x86-64 kernel. This doesn't conclusively tell us whether it's running a x86-64 userland, but the bots should all be running Ubuntu where the kernel bitness is the same as the userland bitness. > Is it possible that this bot just doesn't have a 32bit libelf installed, > and > nobody noticed so far as it wasn't needed on that bot until now? Right, but this is assuming the bot has an x86-64 userland. :-) It has the x86-64 libelf and libelf-dev installed. You might be able to add "libelf1:i386" to the list of dependencies to apt-get install. Cheers, Mark -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
On Wed, Jun 18, 2014 at 1:09 PM, Mark Seaborn <mseaborn@chromium.org> wrote: > x86-64 libelf and libelf-dev installed. You might be able to add > "libelf1:i386" to the list of dependencies to apt-get install. libelf-dev:i386 is what you need (libelf1:i386 will come in as a dependency). On my gPrecise machine, it does work to install that alongside the x86_64 packages (though I haven't tried a build that uses it). -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
Thanks for the replies! I had missed the GYP_DEFINES=target_arch=ia32 on the bot's output (despite trying to look for it), and since most files were compiled with -m32 I inferred that the default target_arch must've been ia32. Thanks for clearing that up. On my local 64bit precise box, I verified that a GYP_DEFINES=target_arch=ia32 build: * Works at head * Is broken if I reapply this change * Works if I `apt-get install libelf-dev:i386` in addition to applying this change Is it possible to just install libelf-dev:i386 on precise-32-glibc-dbg? If so, what's the process for this? If not, the alternative is to add a host_arch to nacl's build/common.gypi that's initialized to the same thing as target_arch, and then only remove the m flags if host_arch==x64 (the bot only overrides target_arch, so it'd be active there). If possible, installing the 32bit libelf on the bot seems nicer to me. On Wed, Jun 18, 2014 at 1:16 PM, Roland McGrath <mcgrathr@google.com> wrote: > On Wed, Jun 18, 2014 at 1:09 PM, Mark Seaborn <mseaborn@chromium.org> > wrote: > > x86-64 libelf and libelf-dev installed. You might be able to add > > "libelf1:i386" to the list of dependencies to apt-get install. > > libelf-dev:i386 is what you need (libelf1:i386 will come in as a > dependency). > On my gPrecise machine, it does work to install that alongside the > x86_64 packages (though I haven't tried a build that uses it). > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
On Wed, Jun 18, 2014 at 4:07 AM, <mseaborn@chromium.org> wrote: > Rubber-stamp LGTM > > Was that hack there because we used to support building Chromium with > x86-32 > multilib libraries installed on a mainly-x86-64 system? That got broken > with > Ubuntu Precise (which doesn't have enough multilib libraries), and so > building > for x86-32 Linux requires at least a chroot, which sounds like your use > case? > > FWIW this is the configuration our team is using for our daily work right now. On Ubuntu Precise. It works (although it's not that easy to setup) and it'll be a pity to see it broken. > > https://codereview.chromium.org/341573003/ > > -- > You received this message because you are subscribed to the Google Groups > "Native-Client-Reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to native-client-reviews+unsubscribe@googlegroups.com. > To post to this group, send email to native-client-reviews@ > googlegroups.com. > Visit this group at http://groups.google.com/group/native-client-reviews. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
On Wed, Jun 18, 2014 at 1:50 PM, Victor Khimenko <khim@chromium.org> wrote: > > > > On Wed, Jun 18, 2014 at 4:07 AM, <mseaborn@chromium.org> wrote: > >> Rubber-stamp LGTM >> >> Was that hack there because we used to support building Chromium with >> x86-32 >> multilib libraries installed on a mainly-x86-64 system? That got broken >> with >> Ubuntu Precise (which doesn't have enough multilib libraries), and so >> building >> for x86-32 Linux requires at least a chroot, which sounds like your use >> case? >> >> FWIW this is the configuration our team is using for our daily work right > now. On Ubuntu Precise. It works (although it's not that easy to setup) and > it'll be a pity to see it broken. > From further up: """ On my local 64bit precise box, I verified that a GYP_DEFINES=target_arch=ia32 build: * Works at head * Is broken if I reapply this change * Works if I `apt-get install libelf-dev:i386` in addition to applying this change Is it possible to just install libelf-dev:i386 on precise-32-glibc-dbg? If so, what's the process for this? If not, the alternative is to add a host_arch to nacl's build/common.gypi that's initialized to the same thing as target_arch, and then only remove the m flags if host_arch==x64 (the bot only overrides target_arch, so it'd be active there). If possible, installing the 32bit libelf on the bot seems nicer to me. """ So if this lands, you'd just have to run `apt-get install libelf-dev:i386` and it'd continue to work. > >> >> https://codereview.chromium.org/341573003/ >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Native-Client-Reviews" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to native-client-reviews+unsubscribe@googlegroups.com. >> To post to this group, send email to native-client-reviews@ >> googlegroups.com. >> Visit this group at http://groups.google.com/group/native-client-reviews. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
On Thu, Jun 19, 2014 at 12:52 AM, Nico Weber <thakis@chromium.org> wrote: > On Wed, Jun 18, 2014 at 1:50 PM, Victor Khimenko <khim@chromium.org> > wrote: > >> >> >> >> On Wed, Jun 18, 2014 at 4:07 AM, <mseaborn@chromium.org> wrote: >> >>> Rubber-stamp LGTM >>> >>> Was that hack there because we used to support building Chromium with >>> x86-32 >>> multilib libraries installed on a mainly-x86-64 system? That got broken >>> with >>> Ubuntu Precise (which doesn't have enough multilib libraries), and so >>> building >>> for x86-32 Linux requires at least a chroot, which sounds like your use >>> case? >>> >>> FWIW this is the configuration our team is using for our daily work >> right now. On Ubuntu Precise. It works (although it's not that easy to >> setup) and it'll be a pity to see it broken. >> > > From further up: """ > On my local 64bit precise box, I verified that a > GYP_DEFINES=target_arch=ia32 build: > * Works at head > * Is broken if I reapply this change > * Works if I `apt-get install libelf-dev:i386` in addition to applying > this change > > Is it possible to just install libelf-dev:i386 on precise-32-glibc-dbg? If > so, what's the process for this? > > If not, the alternative is to add a host_arch to nacl's build/common.gypi > that's initialized to the same thing as target_arch, and then only remove > the m flags if host_arch==x64 (the bot only overrides target_arch, so it'd > be active there). > > If possible, installing the 32bit libelf on the bot seems nicer to me. > """ > > So if this lands, you'd just have to run `apt-get install libelf-dev:i386` > and it'd continue to work. > > No problem then. We are forced to install additional dev packages from time to time, it's not a big deal. -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
The procedure is to add the requirement to chromium/src/build/install-build-deps.sh and then file an infrastructure ticket to ask that it be re-run on relevant bots. That's the only way to ensure that it doesn't get lost next time they reinstall bots. -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
Huh, that's used by the nacl bots too? Ok, I'll give that a try then, thanks :-) On Wed, Jun 18, 2014 at 1:54 PM, Roland McGrath <mcgrathr@google.com> wrote: > The procedure is to add the requirement to > chromium/src/build/install-build-deps.sh and then file an > infrastructure ticket to ask that it be re-run on relevant bots. > That's the only way to ensure that it doesn't get lost next time they > reinstall bots. > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
I'm told that the script has been run on all linux slaves. I'll try relanding this change. On Wed, Jun 18, 2014 at 1:56 PM, Nico Weber <thakis@chromium.org> wrote: > Huh, that's used by the nacl bots too? Ok, I'll give that a try then, > thanks :-) > > > On Wed, Jun 18, 2014 at 1:54 PM, Roland McGrath <mcgrathr@google.com> > wrote: > >> The procedure is to add the requirement to >> chromium/src/build/install-build-deps.sh and then file an >> infrastructure ticket to ask that it be re-run on relevant bots. >> That's the only way to ensure that it doesn't get lost next time they >> reinstall bots. >> > > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
r13400. If the bots don't reject it immediately, I'll send a heads-up somewhere. (Where? nacl-eng?) On Tue, Jun 24, 2014 at 3:26 PM, Nico Weber <thakis@chromium.org> wrote: > I'm told that the script has been run on all linux slaves. I'll try > relanding this change. > > > On Wed, Jun 18, 2014 at 1:56 PM, Nico Weber <thakis@chromium.org> wrote: > >> Huh, that's used by the nacl bots too? Ok, I'll give that a try then, >> thanks :-) >> >> >> On Wed, Jun 18, 2014 at 1:54 PM, Roland McGrath <mcgrathr@google.com> >> wrote: >> >>> The procedure is to add the requirement to >>> chromium/src/build/install-build-deps.sh and then file an >>> infrastructure ticket to ask that it be re-run on relevant bots. >>> That's the only way to ensure that it doesn't get lost next time they >>> reinstall bots. >>> >> >> > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
On 24 June 2014 15:33, Nico Weber <thakis@chromium.org> wrote: > r13400. If the bots don't reject it immediately, I'll send a heads-up > somewhere. (Where? nacl-eng?) > native-client-dev is generally preferred over nacl-eng because it's the public mailing list: https://groups.google.com/forum/#!forum/native-client-dev Cheers, Mark -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
On Tue, Jun 24, 2014 at 3:36 PM, Mark Seaborn <mseaborn@chromium.org> wrote: > On 24 June 2014 15:33, Nico Weber <thakis@chromium.org> wrote: > >> r13400. If the bots don't reject it immediately, I'll send a heads-up >> somewhere. (Where? nacl-eng?) >> > > native-client-dev is generally preferred over nacl-eng because it's the > public mailing list: > https://groups.google.com/forum/#!forum/native-client-dev > Thanks! "Your topic has been created and will appear after it has been approved." :-) > > Cheers, > Mark > > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at http://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout. |
