Issue 341573002: keyboard: Fix hit-testing code to not create the keyboard window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341573002: keyboard: Fix hit-testing code to not create the keyboard window. (Closed)

Created:
6 years, 6 months ago by sadrul

Modified:
6 years, 6 months ago

Reviewers:
kevers

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

keyboard: Fix hit-testing code to not create the keyboard window. KeyboardControllerProxy::GetKeyboardWindow() can create the keyboard window if it's not already created. So during hit-testing, use HasKeyboardWindow() to first determine if the window exists, before using GetKeyboardWindow(). BUG=380215 R=kevers@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277854

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -9 lines)			Patch
	M	ui/keyboard/keyboard_controller.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
	M	ui/keyboard/keyboard_controller_unittest.cc	View		3 chunks	+44 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sadrul

6 years, 6 months ago (2014-06-17 20:31:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r277854 (presubmit successful).

Expand Messages | Collapse Messages