Theme Preferences for Distilled Pages

components/dom_distiller/core/distilled_page_prefs.cc

Index: components/dom_distiller/core/distilled_page_prefs.cc
diff --git a/components/dom_distiller/core/distilled_page_prefs.cc b/components/dom_distiller/core/distilled_page_prefs.cc
new file mode 100644
index 0000000000000000000000000000000000000000..30d599525ea119942095e53b59f04a6927f81a2c
--- /dev/null
+++ b/components/dom_distiller/core/distilled_page_prefs.cc
@@ -0,0 +1,68 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/dom_distiller/core/distilled_page_prefs.h"
+
+#include "base/bind.h"
+#include "base/memory/weak_ptr.h"
+#include "base/message_loop/message_loop.h"
+#include "base/observer_list.h"
+#include "base/prefs/pref_service.h"
+#include "components/pref_registry/pref_registry_syncable.h"
+
+namespace {
+
+// Path to the integer corresponding to user's preference theme.
+const char kThemePref[] = "dom_distiller.theme";
+}
+
+namespace dom_distiller {
+
+DistilledPagePrefs::DistilledPagePrefs(PrefService* pref_service)
+    : pref_service_(pref_service), weak_ptr_factory_(this) {
+}
+
+DistilledPagePrefs::~DistilledPagePrefs() {
+}
+
+// static
+void DistilledPagePrefs::RegisterProfilePrefs(
+    user_prefs::PrefRegistrySyncable* registry) {
+  registry->RegisterIntegerPref(
+      kThemePref,
+      Theme::LIGHT,
+      user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
+}
+
+void DistilledPagePrefs::SetTheme(Theme new_theme) {
+  pref_service_->SetInteger(kThemePref, new_theme);
+  base::MessageLoop::current()->PostTask(
+      FROM_HERE,
+      base::Bind(&DistilledPagePrefs::NotifyOnChangeTheme,
+                 weak_ptr_factory_.GetWeakPtr(),
+                 new_theme));
+}
+
+const DistilledPagePrefs::Theme DistilledPagePrefs::GetTheme() {
+  int theme = pref_service_->GetInteger(kThemePref);
+  if (theme < 0 || theme >= Theme::THEME_COUNT) {
+    SetTheme(Theme::LIGHT);

[nyquist, 2014/07/09 20:38:32]

Nit: Add a comment saying something like "persisted data was incorrectly read,
so try to clean up by storing the default."

[smaslo, 2014/07/10 17:01:06]

Done.

+    return Theme::LIGHT;
+  }
+  return (Theme) theme;
+}
+
+void DistilledPagePrefs::AddObserver(Observer* obs) {
+  observers_.AddObserver(obs);
+}
+
+void DistilledPagePrefs::RemoveObserver(Observer* obs) {
+  observers_.RemoveObserver(obs);
+}
+
+void DistilledPagePrefs::NotifyOnChangeTheme(Theme new_theme) {
+  FOR_EACH_OBSERVER(Observer, observers_, OnChangeTheme(new_theme));
+}
+
+}  // namespace dom_distiller