Theme Preferences for Distilled Pages

components/dom_distiller/core/reader_mode_preferences.cc

Index: components/dom_distiller/core/reader_mode_preferences.cc
diff --git a/components/dom_distiller/core/reader_mode_preferences.cc b/components/dom_distiller/core/reader_mode_preferences.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e157ff40c5d4216b3377deac9a95554d7813e8b8
--- /dev/null
+++ b/components/dom_distiller/core/reader_mode_preferences.cc
@@ -0,0 +1,57 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/dom_distiller/core/reader_mode_preferences.h"
+
+#include "base/observer_list.h"
+#include "base/prefs/pref_service.h"
+#include "components/pref_registry/pref_registry_syncable.h"
+
+namespace {
+
+// True if user prefers high-contrast (dark) appearance when in reader mode.
+const char kThemePref[] = "dom_distiller.theme";
+
+}
+
+namespace dom_distiller {
+
+ReaderModePrefs::ReaderModePrefs(PrefService* pref_service)
+    : pref_service_(pref_service) {
+}
+
+ReaderModePrefs::~ReaderModePrefs() {
+}
+
+void ReaderModePrefs::AddObserver(Observer* obs) {
+  observers_.AddObserver(obs);
+}
+
+void ReaderModePrefs::RemoveObserver(Observer* obs) {
+  observers_.RemoveObserver(obs);
+}
+
+// static
+void ReaderModePrefs::RegisterProfilePrefs(
+    user_prefs::PrefRegistrySyncable* registry) {
+  registry->RegisterIntegerPref(kThemePref,
+      Theme::kLight,
+      user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
+}
+
+void ReaderModePrefs::SetTheme(Theme new_theme) {

[nyquist, 2014/06/30 21:35:41]

Could you add a test for this, ensuring that values are set correctly, and that
the observers are also called?

[smaslo, 2014/07/07 17:14:14]

Done.

+  pref_service_->SetInteger(kThemePref, new_theme);
+  NotifyOnChangeTheme(new_theme);

[nyquist, 2014/06/30 21:35:41]

This should be called in a new task.
MessageLoop::current()::PostTask(...)

[smaslo, 2014/07/07 17:14:15]

Done.

+}
+
+void ReaderModePrefs::NotifyOnChangeTheme(Theme new_theme) {
+  FOR_EACH_OBSERVER(Observer, observers_, OnChangeTheme(new_theme));
+}
+
+const ReaderModePrefs::Theme ReaderModePrefs::GetTheme() const {
+  return (Theme) pref_service_->GetInteger(kThemePref);
+}
+
+}  // namespace dom_distiller
+