Theme Preferences for Distilled Pages

components/dom_distiller/core/reader_mode_preferences.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DOM_DISTILLER_CORE_READER_MODE_PREFERENCES_H_
+#define COMPONENTS_DOM_DISTILLER_CORE_READER_MODE_PREFERENCES_H_
+
+#include "base/macros.h"
+#include "base/observer_list.h"
+
+class PrefService;
+
+namespace user_prefs {
+class PrefRegistrySyncable;
+}
+
+namespace dom_distiller {
+
+// Interface for preferences used in reader mode view.
+class ReaderModePrefs {

[nyquist, 2014/06/30 21:35:41]

Rename this across the board to DistilledPagePrefs, including in the change
description.

[smaslo, 2014/07/07 17:14:15]

I removed it from the code and the issue description.  Is the issue description
the same thing as the change description?  I could not get rid of it from the
patches, though - you still see reader_mode_preferences.cc and
reader_mode_preferences.h.

On 2014/06/30 21:35:41, nyquist wrote:

+ public:
+  // Possible themes for reader mode.
+  enum Theme {
+    kLight,
+    kDark,
+    kSepia
+  };
+
+  class Observer {
+   public:
+    virtual void OnChangeTheme(Theme theme) = 0;
+  };
+
+  static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
+
+  void AddObserver(Observer* obs);
+  void RemoveObserver(Observer* obs);
+
+  explicit ReaderModePrefs(PrefService* pref_service);
+  ~ReaderModePrefs();
+
+  void SetTheme(Theme new_theme);
+
+  const Theme GetTheme() const;
+
+ private:
+  // Notifies all Observers of new theme.
+  void NotifyOnChangeTheme(Theme theme);
+
+  PrefService* pref_service_;
+  ObserverList<Observer> observers_;
+
+  DISALLOW_COPY_AND_ASSIGN(ReaderModePrefs);
+};
+
+}  // namespace dom_distiller
+
+#endif  // COMPONENTS_DOM_DISTILLER_CORE_READER_MODE_PREFERENCES_H_