Theme Preferences for Distilled Pages

chrome/browser/dom_distiller/lazy_dom_distiller_service.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOM_DISTILLER_LAZY_DOM_DISTILLER_SERVICE_H_
 #define CHROME_BROWSER_DOM_DISTILLER_LAZY_DOM_DISTILLER_SERVICE_H_
 
 #include "components/dom_distiller/core/dom_distiller_service.h"
 #include "components/dom_distiller/core/task_tracker.h"
 #include "content/public/browser/notification_observer.h"
@@ skipping 36 matching lines @@
       const std::string& entry_id) OVERRIDE;
   virtual scoped_ptr<ViewerHandle> ViewUrl(
       ViewRequestDelegate* delegate,
       scoped_ptr<DistillerPage> distiller_page,
       const GURL& url) OVERRIDE;
   virtual scoped_ptr<DistillerPage> CreateDefaultDistillerPage() OVERRIDE;
   virtual scoped_ptr<DistillerPage> CreateDefaultDistillerPageWithHandle(
       scoped_ptr<SourcePageHandle> handle) OVERRIDE;
   virtual void AddObserver(DomDistillerObserver* observer) OVERRIDE;
   virtual void RemoveObserver(DomDistillerObserver* observer) OVERRIDE;
-
+  virtual ReaderModePrefs* GetReaderModePrefs() OVERRIDE;

[robliao, 2014/06/17 18:01:49]

Add linebreak after this line.

Also make this method const (like GetSyncableService). 

[smaslo, 2014/06/17 22:44:07]

Done.

  private:
   // Accessor method for the backing service instance.
   DomDistillerServiceInterface* instance() const;
 
   // content::NotificationObserver implementation:
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details) OVERRIDE;
 
   // The Profile to use when retrieving the DomDistillerService and also the
   // profile to listen for destruction of.
   Profile* profile_;
 
   // A BrowserContextKeyedServiceFactory for the DomDistillerService.
   const DomDistillerServiceFactory* service_factory_;
 
+  // An instance of ReaderModePrefs for the DomDistillerService.
+  scoped_ptr<ReaderModePrefs> reader_mode_prefs;

[robliao, 2014/06/17 18:01:49]

Add underscore at the end for member variables.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variab...

[smaslo, 2014/06/17 22:44:07]

Done.

+
   // Used to track when the profile is shut down.
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(LazyDomDistillerService);
 };
 
 }  // namespace dom_distiller
 
 #endif  // CHROME_BROWSER_DOM_DISTILLER_LAZY_DOM_DISTILLER_SERVICE_H_