Theme Preferences for Distilled Pages

components/dom_distiller/core/reader_mode_preferences.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_DOM_DISTILLER_CORE_READER_MODE_SETTINGS_H_
+#define COMPONENTS_DOM_DISTILLER_CORE_READER_MODE_SETTINGS_H_
+
+#include <string>

[battre, 2014/06/23 08:37:23]

Not used.

[smaslo, 2014/06/23 22:14:33]

Done.

+
+class PrefService;

[battre, 2014/06/23 08:37:23]

Not used

[smaslo, 2014/06/23 22:14:33]

Done.

+class Profile;
+
+namespace user_prefs {
+class PrefRegistrySyncable;
+}
+
+namespace dom_distiller {
+
+class ReaderModePrefs {
+ public:
+  ReaderModePrefs(Profile* profile);

[battre, 2014/06/23 08:37:23]

explicit

Please pass the PrefService instead of the profile.

[smaslo, 2014/06/23 22:14:33]

Done.

+  static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
+  void OnChangeHighContrast(bool new_value);
+  bool GetHighContrastPref();

[battre, 2014/06/23 08:37:23]

Nit: Mark as const?

Please add a comment what true and false represent.

[nyquist, 2014/06/23 16:03:06]

As a suggestion, one easy-to-read way of documenting a bool value is by using
'whether'. For example you could write something like:
// Returns whether high contrast mode should be used.

[smaslo, 2014/06/23 22:14:33]

Done.

[smaslo, 2014/06/23 22:14:33]

Done.

+
+ private:
+  Profile* profile_;
+};
+
+}  // namespace dom_distiller
+
+#endif  // COMPONENTS_DOM_DISTILLER_CORE_READER_MODE_SETTINGS_H_