Theme Preferences for Distilled Pages

components/dom_distiller/core/reader_mode_preferences.cc

+// Copyright 2014 The Chromium Authros. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/dom_distiller/core/reader_mode_preferences.h"
+
+#include <string>
+#include <vector>
+
+#include "base/prefs/pref_service.h"
+#include "base/strings/string_util.h"
+#include "chrome/browser/profiles/profile.h"
+#include "components/dom_distiller/core/dom_distiller_pref_names.h"
+#include "components/dom_distiller/core/url_constants.h"

[nyquist, 2014/06/23 16:03:06]

Are all these includes in use?

[smaslo, 2014/06/23 22:14:33]

Done.

+#include "components/pref_registry/pref_registry_syncable.h"
+#include "grit/component_resources.h"
+#include "ui/base/resource/resource_bundle.h"
+
+namespace dom_distiller {
+
+ReaderModePrefs::ReaderModePrefs(Profile* profile)
+    : profile_(profile) {
+}
+
+void ReaderModePrefs::RegisterProfilePrefs(
+    user_prefs::PrefRegistrySyncable* registry) {
+  registry->RegisterBooleanPref(prefs::kHighContrastPref,
+      false,
+      user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
+}
+
+void ReaderModePrefs::OnChangeHighContrast(bool new_value) {

[battre, 2014/06/23 08:37:23]

WDYT of renaming this to SetHighContrastPref(bool new_value)?

[nyquist, 2014/06/23 16:03:06]

Like battre suggests, having consistent naming across setting and getting the
preference is a good thing.

It is a little bit hard to see what this method or pref does, so maybe use
naming such as:

SetUseHighContrast(bool)
bool GetUseHighContrast()

[smaslo, 2014/06/23 22:14:33]

Done.

[smaslo, 2014/06/23 22:14:33]

Done.

+  profile_->GetPrefs()->SetBoolean(prefs::kHighContrastPref, new_value);

[nyquist, 2014/06/23 16:03:06]

This code and below will become simpler when you just pass in the pref service.

[smaslo, 2014/06/23 22:14:33]

Done.

+}
+
+bool ReaderModePrefs::GetHighContrastPref() {
+  return profile_->GetPrefs()->GetBoolean(prefs::kHighContrastPref);
+}
+
+}  // namespace dom_distiller
+