components/dom_distiller/core/dom_distiller_pref_names.h - Issue 341563002: Theme Preferences for Distilled Pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/core/dom_distiller_pref_names.h

Issue 341563002: Theme Preferences for Distilled Pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Minor change to constant name Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_PREF_NAMES_H_

	6 #define COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_PREF_NAMES_H_

	7

	8 namespace dom_distiller {

	9

	10 namespace prefs {

	11

	12 extern const char kHighContrastPref[];
	nyquist 2014/06/23 16:03:06 Is this in use outside of reader_mode_preferences. Is this in use outside of reader_mode_preferences.cc? Could you just have this constant directly defined in an anonymous namespace in that file and remove this header and the corresponding cc file? smaslo 2014/06/23 22:14:33 Done. Show quoted text On 2014/06/23 16:03:06, nyquist wrote: > Is this in use outside of reader_mode_preferences.cc? Could you just have this > constant directly defined in an anonymous namespace in that file and remove this > header and the corresponding cc file? Done.
	13

	14 } // namespace prefs

	15

	16 } // namespace dom_distiller

	17

	18 #endif // COMPONENTS_DOM_DISTILLER_CORE_DOM_DISTILLER_PREF_NAMES_H_

OLD	NEW