components/dom_distiller/DEPS - Issue 341563002: Theme Preferences for Distilled Pages

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/dom_distiller/DEPS

Issue 341563002: Theme Preferences for Distilled Pages (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Minor change to constant name Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/prefs/browser_prefs.cc ('K') | « components/dom_distiller.gypi ('k') | components/dom_distiller/content/dom_distiller_viewer_source.cc » ('j') | components/dom_distiller/core/dom_distiller_pref_names.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+chrome/browser/profiles",
	battre 2014/06/23 08:37:23 This is against the spirit of components. They sho This is against the spirit of components. They should not depend on the browser. The component should be reusable by iOS and that does not have a chrome/browser/profiles. You can use base/prefs/pref_service.h and inject that into your component. smaslo 2014/06/23 22:14:32 Done. Show quoted text On 2014/06/23 08:37:23, battre wrote: > This is against the spirit of components. They should not depend on the browser. > The component should be reusable by iOS and that does not have a > chrome/browser/profiles. > > You can use base/prefs/pref_service.h and inject that into your component. Done.
	3 "+components/pref_registry",

2 "+grit", # For generated headers.	4 "+grit", # For generated headers.

3 "+jni",	5 "+jni",

4 "+sync/api",	6 "+sync/api",

5 "+sync/protocol",	7 "+sync/protocol",

6 "+third_party/dom_distiller_js",	8 "+third_party/dom_distiller_js",

7 "+third_party/leveldatabase/src/include",	9 "+third_party/leveldatabase/src/include",

8 "+net/base",	10 "+net/base",

9 "+net/http",	11 "+net/http",

10 "+net/url_request",	12 "+net/url_request",

11 "+ui/base/l10n",	13 "+ui/base/l10n",

12 "+ui/base/resource",	14 "+ui/base/resource",

13	15

14 # The dom distiller is a layered component; subdirectories must explicitly	16 # The dom distiller is a layered component; subdirectories must explicitly

15 # introduce the ability to use the content layer as appropriate.	17 # introduce the ability to use the content layer as appropriate.

16 # http://www.chromium.org/developers/design-documents/layered-components-desig n	18 # http://www.chromium.org/developers/design-documents/layered-components-desig n

17 "-components/dom_distiller",	19 "-components/dom_distiller",

18 "+components/dom_distiller/core",	20 "+components/dom_distiller/core",

19 ]	21 ]

OLD	NEW