Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1250)

Issue 341553006: Delete prefix-set if side-effect-free whitelist not enabled. (Closed)

Created:
6 years, 6 months ago by Scott Hess - ex-Googler
Modified:
6 years, 6 months ago
Reviewers:
tburkard
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Delete prefix-set if side-effect-free whitelist not enabled. The code was correctly deleting the main safe-browsing store in this case, but left the associated filter file stranded. BUG=none R=tburkard@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278253

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_database.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Scott Hess - ex-Googler
6 years, 6 months ago (2014-06-17 23:51:12 UTC) #1
tburkard
lgtm
6 years, 6 months ago (2014-06-18 08:46:46 UTC) #2
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 6 months ago (2014-06-18 13:27:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/341553006/1
6 years, 6 months ago (2014-06-18 13:28:20 UTC) #4
Scott Hess - ex-Googler
The CQ bit was unchecked by shess@chromium.org
6 years, 6 months ago (2014-06-18 19:52:06 UTC) #5
Scott Hess - ex-Googler
The CQ bit was checked by shess@chromium.org
6 years, 6 months ago (2014-06-18 19:52:09 UTC) #6
Scott Hess - ex-Googler
On 2014/06/18 19:52:09, shess wrote: > The CQ bit was checked by mailto:shess@chromium.org re-starting because ...
6 years, 6 months ago (2014-06-18 19:52:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/341553006/1
6 years, 6 months ago (2014-06-18 19:53:40 UTC) #8
Scott Hess - ex-Googler
On 2014/06/18 19:53:40, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 6 months ago (2014-06-19 02:42:53 UTC) #9
Scott Hess - ex-Googler
On 2014/06/19 02:42:53, shess wrote: > On 2014/06/18 19:53:40, I haz the power (commit-bot) wrote: ...
6 years, 6 months ago (2014-06-19 02:46:05 UTC) #10
Scott Hess - ex-Googler
6 years, 6 months ago (2014-06-19 03:19:14 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 manually as r278253 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698