Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 341553005: Move of SdchDictionaryFetcher to net. (Closed)

Created:
6 years, 6 months ago by Randy Smith (Not in Mondays)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Sync'd to r278311. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -235 lines) Patch
M chrome/browser/io_thread.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/net/sdch_dictionary_fetcher.h View 1 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/browser/net/sdch_dictionary_fetcher.cc View 1 1 chunk +0 lines, -102 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
A + net/base/sdch_dictionary_fetcher.h View 1 4 chunks +16 lines, -14 lines 0 comments Download
A + net/base/sdch_dictionary_fetcher.cc View 1 4 chunks +17 lines, -14 lines 0 comments Download
M net/base/sdch_manager.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/net.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Randy Smith (Not in Mondays)
Jim: PTAL?
6 years, 6 months ago (2014-06-18 13:20:41 UTC) #1
jar (doing other things)
lgtm
6 years, 6 months ago (2014-06-18 15:18:36 UTC) #2
Randy Smith (Not in Mondays)
Scott: Willing to stamp chrome/browser/io_thread.cc and chrome/browser/profiles?
6 years, 6 months ago (2014-06-18 16:19:08 UTC) #3
sky
LGTM
6 years, 6 months ago (2014-06-18 17:16:20 UTC) #4
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org
6 years, 6 months ago (2014-06-18 17:18:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/341553005/1
6 years, 6 months ago (2014-06-18 17:19:51 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 01:29:32 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/browser/io_thread.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-19 01:29:33 UTC) #8
Randy Smith (Not in Mondays)
The CQ bit was checked by rdsmith@chromium.org
6 years, 6 months ago (2014-06-19 18:25:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdsmith@chromium.org/341553005/20001
6 years, 6 months ago (2014-06-19 18:27:53 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 00:12:55 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 04:28:52 UTC) #12
Message was sent while issue was closed.
Change committed as 278587

Powered by Google App Engine
This is Rietveld 408576698