mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc - Issue 341553002: Remove OnRootRemoved from ViewManagerDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

Issue 341553002: Remove OnRootRemoved from ViewManagerDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/examples/nesting_app/nesting_app.cc ('K') | « mojo/examples/nesting_app/nesting_app.cc ('k') | mojo/services/public/cpp/view_manager/view_manager_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

diff --git a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

index 772b1d6c10e3e89fd80d6bd795e4c3c901c1f67b..4e811da50dc593cfb01e1210961624f00f11b625 100644

--- a/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

+++ b/mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc

@@ -815,10 +815,8 @@ void ViewManagerClientImpl::AddRoot(Node* root) {

void ViewManagerClientImpl::RemoveRoot(Node* root) {

std::vector<Node*>::iterator it =

std::find(roots_.begin(), roots_.end(), root);

- if (it != roots_.end()) {

+ if (it != roots_.end())

roots_.erase(it);

- delegate_->OnRootRemoved(this, root);

- }

}

////////////////////////////////////////////////////////////////////////////////