Issue 341553002: Remove OnRootRemoved from ViewManagerDelegate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 341553002: Remove OnRootRemoved from ViewManagerDelegate (Closed)

Created:
6 years, 6 months ago by Ben Goodger (Google)

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove OnRootRemoved from ViewManagerDelegate It's duplicative with NodeObserver::OnDestroy. R=sky@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277913

Patch Set 2 : . #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -22 lines)			Patch
M	mojo/examples/browser/browser.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	mojo/examples/embedded_app/embedded_app.cc	View	1	3 chunks	+12 lines, -9 lines	0 comments	Download
M	mojo/examples/nesting_app/nesting_app.cc	View	1	3 chunks	+14 lines, -6 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/lib/view_manager_client_impl.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	mojo/services/public/cpp/view_manager/view_manager_delegate.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/341553002/diff/1/mojo/examples/nesting_app/nesting_app.cc File mojo/examples/nesting_app/nesting_app.cc (right): https://codereview.chromium.org/341553002/diff/1/mojo/examples/nesting_app/nesting_app.cc#newcode105 mojo/examples/nesting_app/nesting_app.cc:105: nit: only one newline.

6 years, 6 months ago (2014-06-17 16:56:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/341553002/20001

6 years, 6 months ago (2014-06-17 18:05:27 UTC) #4

Message was sent while issue was closed.

Change committed as 277913

Expand Messages | Collapse Messages

Issue 341553002: Remove OnRootRemoved from ViewManagerDelegate (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages