DevTools: make responsive design a master switch for emulation.

Source/devtools/front_end/sdk/OverridesSupport.js

Index: Source/devtools/front_end/sdk/OverridesSupport.js
diff --git a/Source/devtools/front_end/sdk/OverridesSupport.js b/Source/devtools/front_end/sdk/OverridesSupport.js
index 87abf76c7f41650d07f184df63993f16107b6c84..09304cffd4d9b9437c77bf994b965293b3e04c87 100644
--- a/Source/devtools/front_end/sdk/OverridesSupport.js
+++ b/Source/devtools/front_end/sdk/OverridesSupport.js
@@ -480,9 +480,9 @@ WebInspector.OverridesSupport.prototype = {
     /**
      * @return {boolean}
      */
-    responsiveDesignAvailable: function()
+    _responsiveDesignEnabledOrUnavailable: function()
     {
-        return this._responsiveDesignAvailable;
+        return !this._responsiveDesignAvailable || WebInspector.settings.responsiveDesignEnabled.get();
     },
 
     /**
@@ -573,9 +573,11 @@ WebInspector.OverridesSupport.prototype = {
 
         this.settings.overrideGeolocation.addChangeListener(this._geolocationPositionChanged, this);
         this.settings.geolocationOverride.addChangeListener(this._geolocationPositionChanged, this);
+        WebInspector.settings.responsiveDesignEnabled.addChangeListener(this._geolocationPositionChanged, this);
 
         this.settings.overrideDeviceOrientation.addChangeListener(this._deviceOrientationChanged, this);
         this.settings.deviceOrientationOverride.addChangeListener(this._deviceOrientationChanged, this);
+        WebInspector.settings.responsiveDesignEnabled.addChangeListener(this._deviceOrientationChanged, this);
 
         this._addEmulateDeviceListener(this._emulateTouchEventsChanged);
         this.settings.deviceTouch.addChangeListener(this._emulateTouchEventsChanged, this);
@@ -583,10 +585,14 @@ WebInspector.OverridesSupport.prototype = {
 
         this.settings.overrideCSSMedia.addChangeListener(this._cssMediaChanged, this);
         this.settings.emulatedCSSMedia.addChangeListener(this._cssMediaChanged, this);
+        WebInspector.settings.responsiveDesignEnabled.addChangeListener(this._cssMediaChanged, this);
 
-        this.settings.emulateNetworkConditions.addChangeListener(this._networkConditionsChanged, this);
-        this.settings.networkConditionsDomains.addChangeListener(this._networkConditionsChanged, this);
-        this.settings.networkConditionsThroughput.addChangeListener(this._networkConditionsChanged, this);
+        if (WebInspector.experimentsSettings.networkConditions.isEnabled()) {
+            this.settings.emulateNetworkConditions.addChangeListener(this._networkConditionsChanged, this);
+            this.settings.networkConditionsDomains.addChangeListener(this._networkConditionsChanged, this);
+            this.settings.networkConditionsThroughput.addChangeListener(this._networkConditionsChanged, this);
+            WebInspector.settings.responsiveDesignEnabled.addChangeListener(this._networkConditionsChanged, this);
+        }
 
         WebInspector.settings.showMetricsRulers.addChangeListener(this._showRulersChanged, this);
 
@@ -608,7 +614,7 @@ WebInspector.OverridesSupport.prototype = {
         if (this.userAgentOverride())
             this._userAgentChanged();
 
-        if (this.settings.emulateNetworkConditions.get())
+        if (WebInspector.experimentsSettings.networkConditions.isEnabled() && this.settings.emulateNetworkConditions.get())
             this._networkConditionsChanged();
 
         this._showRulersChanged();
@@ -620,7 +626,7 @@ WebInspector.OverridesSupport.prototype = {
     _addEmulateDeviceListener: function(listener)
     {
         this.settings.emulateDevice.addChangeListener(listener, this);
-        WebInspector.settings.responsiveDesign.enabled.addChangeListener(listener, this);
+        WebInspector.settings.responsiveDesignEnabled.addChangeListener(listener, this);
     },
 
     _userAgentChanged: function()
@@ -661,9 +667,8 @@ WebInspector.OverridesSupport.prototype = {
 
         if (this._deviceMetricsChangedListenerMuted)
             return;
-        var responsiveDesignAvailableAndDisabled = this._responsiveDesignAvailable && (!WebInspector.settings.responsiveDesign.enabled.get() || !this._pageResizer);
         var emulateDevice = this.settings.emulateDevice.get();
-        if (responsiveDesignAvailableAndDisabled || !emulateDevice) {

[dgozman, 2014/06/17 16:20:48]

This is now broken.

[pfeldman, 2014/06/17 16:25:03]

Oops. Thanks.

+        if (!emulateDevice) {
             this._deviceMetricsThrottler.schedule(clearDeviceMetricsOverride.bind(this));
             if (this._pageResizer && !emulateDevice)
                 this._pageResizer.update(0, 0, 0);
@@ -746,7 +751,7 @@ WebInspector.OverridesSupport.prototype = {
 
     _geolocationPositionChanged: function()
     {
-        if (!this.settings.overrideGeolocation.get()) {
+        if (!this._responsiveDesignEnabledOrUnavailable() || !this.settings.overrideGeolocation.get()) {
             GeolocationAgent.clearGeolocationOverride();
             return;
         }
@@ -760,7 +765,7 @@ WebInspector.OverridesSupport.prototype = {
 
     _deviceOrientationChanged: function()
     {
-        if (!this.settings.overrideDeviceOrientation.get()) {
+        if (!this._responsiveDesignEnabledOrUnavailable() || !this.settings.overrideDeviceOrientation.get()) {
             PageAgent.clearDeviceOrientationOverride();
             return;
         }
@@ -784,7 +789,7 @@ WebInspector.OverridesSupport.prototype = {
         if (this.isInspectingDevice() && this.settings.overrideCSSMedia.get())
             return;
 
-        PageAgent.setEmulatedMedia(this.settings.overrideCSSMedia.get() ? this.settings.emulatedCSSMedia.get() : "");
+        PageAgent.setEmulatedMedia(this._responsiveDesignEnabledOrUnavailable() && this.settings.overrideCSSMedia.get() ? this.settings.emulatedCSSMedia.get() : "");
         var targets = WebInspector.targetManager.targets();
         for (var i = 0; i < targets.length; ++i)
             targets[i].cssModel.mediaQueryResultChanged();
@@ -793,7 +798,7 @@ WebInspector.OverridesSupport.prototype = {
 
     _networkConditionsChanged: function()
     {
-        if (!this.settings.emulateNetworkConditions.get()) {
+        if (!this._responsiveDesignEnabledOrUnavailable() || !this.settings.emulateNetworkConditions.get()) {
             NetworkAgent.emulateNetworkConditions([], 0, false);
         } else {
             var domainsString = this.settings.networkConditionsDomains.get().trim();
@@ -836,6 +841,7 @@ WebInspector.OverridesSupport.prototype = {
             (this.settings.emulateDevice.get() && !this.isInspectingDevice()) ||
             this.settings.overrideGeolocation.get() ||
             this.settings.overrideDeviceOrientation.get() ||
+            this.settings.emulateNetworkConditions.get() ||
             this.isTouchEmulationEnabled() ||
             (this.settings.overrideCSSMedia.get() && !this.isInspectingDevice());
         if (this._hasActiveOverrides !== hasActiveOverrides) {
@@ -952,7 +958,7 @@ WebInspector.OverridesSupport.prototype = {
      */
     isEmulateDeviceEnabled: function()
     {
-        return this.settings.emulateDevice.get() && (!this._responsiveDesignAvailable || WebInspector.settings.responsiveDesign.enabled.get());
+        return this.settings.emulateDevice.get() && WebInspector.settings.responsiveDesignEnabled.get();
     },
 
     /**