Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 341543002: Reland 176261: Fix for select PopupMenuList appearance in rtl mode with overlay-scrollbar enabled. (Closed)

Created:
6 years, 6 months ago by pals
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Reland 176261: Fix for select PopupMenuList appearance in rtl mode with overlay-scrollbar enabled. Disabling the tests as PopupListBox is not used for rendering <select> on android. BUG=385588 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -6 lines) Patch
M Source/platform/scroll/FramelessScrollView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/PopupListBox.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/web/tests/PopupMenuTest.cpp View 7 chunks +52 lines, -2 lines 0 comments Download
A Source/web/tests/data/popup/select_rtl.html View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pals
Please take another look.
6 years, 6 months ago (2014-06-17 14:37:58 UTC) #1
tkent
lgtm
6 years, 6 months ago (2014-06-17 22:27:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sanjoy.pal@samsung.com/341543002/1
6 years, 6 months ago (2014-06-17 22:29:06 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 23:36:29 UTC) #4
Message was sent while issue was closed.
Change committed as 176364

Powered by Google App Engine
This is Rietveld 408576698