pkg/analysis_server/lib/src/context_directory_manager.dart - Issue 341533005: Change contract for ChangeSet to reflect AnalysisContext behavior.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/context_directory_manager.dart

Issue 341533005: Change contract for ChangeSet to reflect AnalysisContext behavior. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/internal/context/AnalysisContextImplTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/context_directory_manager.dart

diff --git a/pkg/analysis_server/lib/src/context_directory_manager.dart b/pkg/analysis_server/lib/src/context_directory_manager.dart

index 7abfda8b3c479256453c9b8bc4e36e5afa996b31..960cd9aece23bdf24676151a7eed8e18bcdf8296 100644

--- a/pkg/analysis_server/lib/src/context_directory_manager.dart

+++ b/pkg/analysis_server/lib/src/context_directory_manager.dart

@@ -137,13 +137,6 @@ abstract class ContextDirectoryManager {

Source source = info.sources[event.path];

if (source != null) {

ChangeSet changeSet = new ChangeSet();

- // TODO(paulberry): technically we should skip calling changedSource()

- // for files that currently have their contents overridden. However,

- // it's hard to figure out which files have their contents overridden

- // (this info isn't exposed through the AnalysisContext interface),

- // and besides, if we go ahead and call changedSource() we get the

- // behavior we want (the context continues consulting the overridden

- // file contents).

changeSet.changedSource(source);

applyChangesToContext(folder, changeSet);

}